Address PR review feedback

- Restore soft-report behavior for compose up/down failures: use
  FailAsync without re-throwing, matching the original non-fatal
  behavior (JamesNK feedback)
- Add EnsureRuntimeAvailableAsync to Podman ComposeListServicesAsync
  override so missing podman binary gets an actionable error
- Make EnsureRuntimeAvailableAsync protected for subclass access
- Rename PascalCase ContainerRuntime locals to camelCase in
  ResourceContainerImageManager

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: davidfowl

src/Aspire.Hosting.Docker/DockerComposeEnvironmentResource.cs

@@ -243,8 +243,7 @@ await deployTask.CompleteAsync(
             }
             catch (Exception ex)
             {
-                await deployTask.CompleteAsync($"Compose deployment failed ({runtime.Name}): {ex.Message}", CompletionState.CompletedWithError, context.CancellationToken).ConfigureAwait(false);
-                throw;
+                await deployTask.FailAsync($"Compose deployment failed ({runtime.Name}): {ex.Message}", cancellationToken: context.CancellationToken).ConfigureAwait(false);
             }
         }
     }
@@ -279,8 +278,7 @@ await deployTask.CompleteAsync(
             }
             catch (Exception ex)
             {
-                await deployTask.CompleteAsync($"Compose shutdown failed ({runtime.Name}): {ex.Message}", CompletionState.CompletedWithError, context.CancellationToken).ConfigureAwait(false);
-                throw;
+                await deployTask.FailAsync($"Compose shutdown failed ({runtime.Name}): {ex.Message}", cancellationToken: context.CancellationToken).ConfigureAwait(false);
             }
         }
     }

src/Aspire.Hosting/Publishing/ContainerRuntimeBase.cs

@@ -536,7 +536,7 @@ private static string BuildComposeArguments(ComposeOperationContext context)
     /// Validates that the container runtime binary is available on the system PATH.
     /// Fails fast with an actionable error message instead of a cryptic exit code.
     /// </summary>
-    private async Task EnsureRuntimeAvailableAsync()
+    protected async Task EnsureRuntimeAvailableAsync()
     {
         try
         {

src/Aspire.Hosting/Publishing/PodmanContainerRuntime.cs

@@ -26,6 +26,8 @@ public PodmanContainerRuntime(ILogger<PodmanContainerRuntime> logger) : base(log
     /// </summary>
     public override async Task<IReadOnlyList<ComposeServiceInfo>?> ComposeListServicesAsync(ComposeOperationContext context, CancellationToken cancellationToken)
     {
+        await EnsureRuntimeAvailableAsync().ConfigureAwait(false);
+
         var arguments = $"ps --filter label=com.docker.compose.project={context.ProjectName} --format json";
 
         var outputLines = new List<string>();

src/Aspire.Hosting/Publishing/ResourceContainerImageManager.cs

@@ -206,23 +206,23 @@ private async Task<ResolvedContainerBuildOptions> ResolveContainerBuildOptionsAs
 
     public async Task BuildImagesAsync(IEnumerable<IResource> resources, CancellationToken cancellationToken = default)
     {
-        var ContainerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
+        var containerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
         logger.LogInformation("Starting to build container images");
 
         // Only check container runtime health if there are resources that need it
         if (await ResourcesRequireContainerRuntimeAsync(resources, cancellationToken).ConfigureAwait(false))
         {
-            logger.LogDebug("Checking {ContainerRuntimeName} health", ContainerRuntime.Name);
+            logger.LogDebug("Checking {ContainerRuntimeName} health", containerRuntime.Name);
 
-            var containerRuntimeHealthy = await ContainerRuntime.CheckIfRunningAsync(cancellationToken).ConfigureAwait(false);
+            var containerRuntimeHealthy = await containerRuntime.CheckIfRunningAsync(cancellationToken).ConfigureAwait(false);
 
             if (!containerRuntimeHealthy)
             {
-                logger.LogError("Container runtime '{ContainerRuntimeName}' is not running or is unhealthy. Cannot build container images.", ContainerRuntime.Name);
-                throw new InvalidOperationException($"Container runtime '{ContainerRuntime.Name}' is not running or is unhealthy.");
+                logger.LogError("Container runtime '{ContainerRuntimeName}' is not running or is unhealthy. Cannot build container images.", containerRuntime.Name);
+                throw new InvalidOperationException($"Container runtime '{containerRuntime.Name}' is not running or is unhealthy.");
             }
 
-            logger.LogDebug("{ContainerRuntimeName} is healthy", ContainerRuntime.Name);
+            logger.LogDebug("{ContainerRuntimeName} is healthy", containerRuntime.Name);
         }
 
         foreach (var resource in resources)
@@ -236,25 +236,25 @@ public async Task BuildImagesAsync(IEnumerable<IResource> resources, Cancellatio
 
     public async Task BuildImageAsync(IResource resource, CancellationToken cancellationToken = default)
     {
-        var ContainerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
+        var containerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
         logger.LogInformation("Building container image for resource {ResourceName}", resource.Name);
 
         var options = await ResolveContainerBuildOptionsAsync(resource, cancellationToken).ConfigureAwait(false);
 
         // Check if this resource needs a container runtime
         if (await ResourcesRequireContainerRuntimeAsync([resource], cancellationToken).ConfigureAwait(false))
         {
-            logger.LogDebug("Checking {ContainerRuntimeName} health", ContainerRuntime.Name);
+            logger.LogDebug("Checking {ContainerRuntimeName} health", containerRuntime.Name);
 
-            var containerRuntimeHealthy = await ContainerRuntime.CheckIfRunningAsync(cancellationToken).ConfigureAwait(false);
+            var containerRuntimeHealthy = await containerRuntime.CheckIfRunningAsync(cancellationToken).ConfigureAwait(false);
 
             if (!containerRuntimeHealthy)
             {
-                logger.LogError("Container runtime '{ContainerRuntimeName}' is not running or is unhealthy. Cannot build container image.", ContainerRuntime.Name);
-                throw new InvalidOperationException($"Container runtime '{ContainerRuntime.Name}' is not running or is unhealthy.");
+                logger.LogError("Container runtime '{ContainerRuntimeName}' is not running or is unhealthy. Cannot build container image.", containerRuntime.Name);
+                throw new InvalidOperationException($"Container runtime '{containerRuntime.Name}' is not running or is unhealthy.");
             }
 
-            logger.LogDebug("{ContainerRuntimeName} is healthy", ContainerRuntime.Name);
+            logger.LogDebug("{ContainerRuntimeName} is healthy", containerRuntime.Name);
         }
 
         if (resource is ProjectResource)
@@ -421,7 +421,7 @@ private async Task<bool> ExecuteDotnetPublishAsync(IResource resource, ResolvedC
 
     private async Task BuildContainerImageFromDockerfileAsync(IResource resource, DockerfileBuildAnnotation dockerfileBuildAnnotation, string imageName, ResolvedContainerBuildOptions options, CancellationToken cancellationToken)
     {
-        var ContainerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
+        var containerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
         logger.LogInformation("Building image: {ResourceName}", resource.Name);
 
         // If there's a factory, generate the Dockerfile content and write it to the specified path
@@ -475,7 +475,7 @@ private async Task BuildContainerImageFromDockerfileAsync(IResource resource, Do
 
         try
         {
-            await ContainerRuntime.BuildImageAsync(
+            await containerRuntime.BuildImageAsync(
                 dockerfileBuildAnnotation.ContextPath,
                 dockerfileBuildAnnotation.DockerfilePath,
                 containerBuildOptions,
@@ -518,8 +518,8 @@ await ContainerRuntime.BuildImageAsync(
 
     public async Task PushImageAsync(IResource resource, CancellationToken cancellationToken)
     {
-        var ContainerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
-        await ContainerRuntime.PushImageAsync(resource, cancellationToken).ConfigureAwait(false);
+        var containerRuntime = await GetContainerRuntimeAsync(cancellationToken).ConfigureAwait(false);
+        await containerRuntime.PushImageAsync(resource, cancellationToken).ConfigureAwait(false);
     }
 
     // .NET Container builds that push OCI images to a local file path do not need a runtime