Skip to content

main is red: RunCommandFailFastAsync used but undefined in TypeScriptEmptyAppHostTemplateTests (introduced by #17575) #17684

@maddymontaquila

Description

@maddymontaquila

Summary

main does not compile its CLI E2E test project, so ci.yml is failing on every PR (and on main itself). This blocks all PR merges until fixed.

Root cause

Commit 4cfc99df7 (PR #17575, "Fix TypeScript AppHost async callback deadlock") added tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs, which calls a helper that does not exist:

tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs(79): await auto.RunCommandFailFastAsync("cd TsDeadlockRepro", counter);
tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs(80): await auto.RunCommandFailFastAsync("aspire restore --non-interactive", counter, TimeSpan.FromMinutes(3));
tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs(81): await auto.RunCommandFailFastAsync("npm run build", counter, TimeSpan.FromMinutes(2));

Hex1bTerminalAutomator (from Hex1b.Automation) exposes RunCommandAsync, which is used everywhere else in the project, but there is no RunCommandFailFastAsync defined anywhere in the repo or the referenced package version. Build fails with:

error CS1061: 'Hex1bTerminalAutomator' does not contain a definition for 'RunCommandFailFastAsync'

Evidence

  • ci.yml is failure on main HEAD 4cfc99df7 (and the prior commit), failing checks Stabilization Check and Tests / Setup for tests.
  • git grep RunCommandFailFastAsync origin/main returns only the three call sites above — no definition.

Suggested fix

Either add the missing RunCommandFailFastAsync helper (a fail-fast variant of RunCommandAsync that asserts non-zero exit fails the test), bump the Hex1b package to a version that provides it, or replace the calls with the existing RunCommandAsync. Alternatively revert #17575 until the helper is available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-engineering-systemsinfrastructure helix infra engineering repo stufftriage:bot-seenAspire triage bot has seen this issue

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions