Allow release gh-aw workflows for bot events#17869
Conversation
Allow the Aspire release bot to activate the release-triggered gh-aw workflows so bot-authored stable releases run the release notes and aspire.dev support-page automation instead of stopping after pre-activation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17869Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17869" |
There was a problem hiding this comment.
Pull request overview
Enables the release-triggered gh-aw workflows to run when the triggering actor is aspire-repo-bot (GitHub App), by allow-listing the bot so the pre-activation membership gate doesn’t treat the event as insufficient_permissions.
Changes:
- Allow-list
aspire-repo-botin therelease-update-support-mdxgh-aw workflow. - Allow-list
aspire-repo-botin therelease-notes-generategh-aw workflow. - Regenerate both workflow lock files so
GH_AW_ALLOWED_BOTSis set in the pre-activation membership check.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release-update-support-mdx.md | Adds bots: [aspire-repo-bot] to allow the bot-authored release event through gh-aw activation. |
| .github/workflows/release-update-support-mdx.lock.yml | Regenerated lock file; includes GH_AW_ALLOWED_BOTS: "aspire-repo-bot" in pre-activation membership check. |
| .github/workflows/release-notes-generate.md | Adds bots: [aspire-repo-bot] to allow the bot-authored release event through gh-aw activation. |
| .github/workflows/release-notes-generate.lock.yml | Regenerated lock file; includes GH_AW_ALLOWED_BOTS: "aspire-repo-bot" in pre-activation membership check. |
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
|
❓ CLI E2E Tests unknown — 112 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26884317052 |
|
✅ No documentation update needed. docs_required → signal is a false positive; no user-facing change Triggered signals (1): The signal fired on the validation command in the PR body:
The flags All 4 changed files are under |
Description
Allow the bot-authored stable release events to activate the release-triggered gh-aw workflows instead of stopping after
pre_activation.The linked run for
Update aspire.dev support page for a new Aspire releasewas triggered byaspire-repo-bot[bot], but gh-aw's activation gate checked the actor's repository permission, sawnone, and skipped the agent, detection, safe output, and conclusion jobs. This addsbots: [aspire-repo-bot]to the release support-page workflow and the companion release-notes workflow, matching the existing bot-triggered gh-aw workflow pattern used byextension-changelog.md, and regenerates the lock files soGH_AW_ALLOWED_BOTSis passed to the pre-activation membership check.Fixes # (issue)
Validation:
gh aw compile release-notes-generate release-update-support-mdx --no-emit --validate --no-check-updateChecklist
<remarks />and<code />elements on your triple slash comments?