-
Notifications
You must be signed in to change notification settings - Fork 887
Show waiting dependency details in dashboard #17089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamint
merged 22 commits into
microsoft:main
from
adamint:dev/adamint/waiting-state-dependency-details
May 19, 2026
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3346ce8
Show waiting dependency details in dashboard
adamint 3ac6f77
Add state description actions
adamint cec54b4
Use localized strings in state detail tests
adamint e9a8191
Refine state description start action
adamint f5e6cbb
Add waiting dependency coverage for all wait types
adamint 3e277f1
Normalize state description punctuation
adamint cc42763
Align state description start action
adamint 0dac353
Make state action fully inline
adamint bdbc841
Align inline state action icon
adamint 0fae2e2
Allow BasketService HTTP health checks
adamint 3818870
Rename state action to Start anyway
adamint 39547d0
Include waiting dependencies in wait cancellation
adamint 86751b5
Address waiting dependency dashboard feedback
adamint a1238ec
Address waiting dependency review feedback
adamint 9c20407
Address waiting dependency review feedback
adamint 23d6f2a
Merge main into waiting dependency details
adamint 12452eb
Fix TestShop build after waiting dependency updates
adamint 00dcf27
Remove manual TestShop start gate
adamint 3126b2b
Fix waiting dependency property export
adamint d05e4da
Preserve structured resource properties in JSON
adamint 8d13578
Merge remote-tracking branch 'microsoft/main' into dev/adamint/waitin…
adamint 0679b59
Fix backchannel property test for JSON values
adamint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,8 @@ public void AddMenuItems( | |
| Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting, | ||
| bool showViewDetails, | ||
| bool showConsoleLogsItem, | ||
| bool showUrls) | ||
| bool showUrls, | ||
| bool showStartCommand = true) | ||
| { | ||
| if (showViewDetails) | ||
| { | ||
|
|
@@ -165,7 +166,7 @@ await _aiContextProvider.LaunchAssistantSidebarAsync( | |
|
|
||
| AddTelemetryMenuItems(menuItems, resource, resourceByName); | ||
|
|
||
| AddCommandMenuItems(menuItems, resource, commandSelected, isCommandExecuting); | ||
| AddCommandMenuItems(menuItems, resource, commandSelected, isCommandExecuting, showStartCommand); | ||
|
|
||
| if (showUrls) | ||
| { | ||
|
|
@@ -282,9 +283,10 @@ private void AddTelemetryMenuItems(List<MenuButtonItem> menuItems, ResourceViewM | |
| } | ||
| } | ||
|
|
||
| private void AddCommandMenuItems(List<MenuButtonItem> menuItems, ResourceViewModel resource, EventCallback<CommandViewModel> commandSelected, Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting) | ||
| private void AddCommandMenuItems(List<MenuButtonItem> menuItems, ResourceViewModel resource, EventCallback<CommandViewModel> commandSelected, Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting, bool showStartCommand) | ||
| { | ||
| var menuCommands = resource.Commands | ||
| .Where(c => showStartCommand || !c.Name.Equals(CommandViewModel.StartCommand, StringComparisons.CommandName)) | ||
|
adamint marked this conversation as resolved.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| .Where(c => c.State != CommandViewModelState.Hidden) | ||
| .ToList(); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed Kestrel HTTP/2-only default was blocking the new HTTP health check on BasketService. This playground change needs
WithHttpHealthCheck("/health", endpointName: "http")so the dashboard can show healthy/starting dependency details for the waiting-state demo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but this breaks the basket service. It needs HTTP/2