-
Notifications
You must be signed in to change notification settings - Fork 887
Show waiting dependency details in dashboard #17089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
3346ce8
3ac6f77
cec54b4
e9a8191
f5e6cbb
3e277f1
cc42763
0dac353
bdbc841
0fae2e2
3818870
39547d0
86751b5
a1238ec
9c20407
23d6f2a
12452eb
00dcf27
3126b2b
d05e4da
8d13578
0679b59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,8 @@ public void AddMenuItems( | |
| Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting, | ||
| bool showViewDetails, | ||
| bool showConsoleLogsItem, | ||
| bool showUrls) | ||
| bool showUrls, | ||
| bool showStartCommand = true) | ||
| { | ||
| if (showViewDetails) | ||
| { | ||
|
|
@@ -165,7 +166,7 @@ await _aiContextProvider.LaunchAssistantSidebarAsync( | |
|
|
||
| AddTelemetryMenuItems(menuItems, resource, resourceByName); | ||
|
|
||
| AddCommandMenuItems(menuItems, resource, commandSelected, isCommandExecuting); | ||
| AddCommandMenuItems(menuItems, resource, commandSelected, isCommandExecuting, showStartCommand); | ||
|
|
||
| if (showUrls) | ||
| { | ||
|
|
@@ -282,9 +283,10 @@ private void AddTelemetryMenuItems(List<MenuButtonItem> menuItems, ResourceViewM | |
| } | ||
| } | ||
|
|
||
| private void AddCommandMenuItems(List<MenuButtonItem> menuItems, ResourceViewModel resource, EventCallback<CommandViewModel> commandSelected, Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting) | ||
| private void AddCommandMenuItems(List<MenuButtonItem> menuItems, ResourceViewModel resource, EventCallback<CommandViewModel> commandSelected, Func<ResourceViewModel, CommandViewModel, bool> isCommandExecuting, bool showStartCommand) | ||
| { | ||
| var menuCommands = resource.Commands | ||
| .Where(c => showStartCommand || !c.Name.Equals(CommandViewModel.StartCommand, StringComparisons.CommandName)) | ||
|
adamint marked this conversation as resolved.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| .Where(c => c.State != CommandViewModelState.Hidden) | ||
| .ToList(); | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,15 +118,15 @@ | |
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | ||
| </resheader> | ||
| <data name="StateColumnResourceExitedUnexpectedly" xml:space="preserve"> | ||
| <value>{0} exited unexpectedly with exit code {1}</value> | ||
| <value>{0} exited unexpectedly with exit code {1}.</value> | ||
| <comment>{0} is a resource type, {1} is a number</comment> | ||
| </data> | ||
| <data name="StateColumnResourceExited" xml:space="preserve"> | ||
| <value>{0} is no longer running</value> | ||
| <value>{0} is no longer running.</value> | ||
| <comment>{0} is a resource type</comment> | ||
| </data> | ||
| <data name="StateColumnResourceFailedToStart" xml:space="preserve"> | ||
| <value>{0} failed to start</value> | ||
| <value>{0} failed to start.</value> | ||
| <comment>{0} is a resource type</comment> | ||
| </data> | ||
| <data name="SourceColumnDisplayCopyCommandToClipboard" xml:space="preserve"> | ||
|
|
@@ -155,13 +155,17 @@ | |
| </data> | ||
| <data name="StateColumnResourceContainerRuntimeUnhealthy" xml:space="preserve"> | ||
| <value>Container runtime was found but appears to be unhealthy. Ensure that it is running. | ||
| For more information, see https://aka.ms/aspire/container-runtime-unhealthy</value> | ||
| For more information, see https://aka.ms/aspire/container-runtime-unhealthy.</value> | ||
| <comment>Contains a new line</comment> | ||
| </data> | ||
| <data name="StateColumnResourceNotStarted" xml:space="preserve"> | ||
| <value>Resource has not started because it's configured to not automatically start.</value> | ||
| <value>Resource is not configured to start automatically.</value> | ||
| </data> | ||
| <data name="StateColumnResourceWaiting" xml:space="preserve"> | ||
| <value>Resource is waiting for other resources to be in a running and healthy state.</value> | ||
| <value>Resource is waiting for dependencies.</value> | ||
| </data> | ||
| <data name="StateColumnResourceWaitingFor" xml:space="preserve"> | ||
| <value>Waiting for dependencies: {0}.</value> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't put fullstop in messages than end with
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: The period after |
||
| <comment>{0} is a comma-separated list of dependency resource names.</comment> | ||
| </data> | ||
| </root> | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed Kestrel HTTP/2-only default was blocking the new HTTP health check on BasketService. This playground change needs
WithHttpHealthCheck("/health", endpointName: "http")so the dashboard can show healthy/starting dependency details for the waiting-state demo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but this breaks the basket service. It needs HTTP/2