Change DataTargetOptions init accessors to set (#1491)

* Change DataTargetOptions init accessors to set to fix cross-asset MissingMethodException

The package multi-targets netstandard2.0 and net10.0. `init` accessors emit
the setter with a required custom modifier (modreq) of
System.Runtime.CompilerServices.IsExternalInit. On netstandard2.0 this type
does not exist in-box, so the compiler synthesizes it inside
Microsoft.Diagnostics.Runtime itself; on net10.0 it resolves to the BCL type
in System.Private.CoreLib.

Because a modreq is signature-significant, set_X carries a different signature
in each asset. A library compiled against the netstandard2.0 asset bakes a call
referencing the embedded IsExternalInit; when a net10+ application unifies ClrMD
to the net10.0 asset at runtime, that method no longer exists and the consumer
gets a MissingMethodException (e.g. a net8/netstandard2.0 library used by a
net10 app).

Reverting every init accessor on DataTargetOptions to set removes the modreq so
set_X is identical across both assets, eliminating the mismatch. The options bag
already mixed init and set (ForceCompleteRuntimeEnumeration was set).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Bump VersionPrefix 4.0.0 -> 4.1.0

The init->set change on DataTargetOptions is a binary-breaking change (removes the IsExternalInit modreq from the setters), so bump the minor version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: leculver

eng/Versions.props

@@ -2,7 +2,7 @@
 <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <!-- This repo version -->
-    <VersionPrefix>4.0.0</VersionPrefix>
+    <VersionPrefix>4.1.0</VersionPrefix>
     <PreReleaseVersionLabel>
     </PreReleaseVersionLabel>
     <DotNetUseShippingVersions>true</DotNetUseShippingVersions>

src/Microsoft.Diagnostics.Runtime/DataTargetOptions.cs

@@ -19,7 +19,7 @@ public class DataTargetOptions
     public CacheOptions CacheOptions
     {
         get => field ??= new CacheOptions();
-        init;
+        set;
     }
 
     /// <summary>
@@ -28,7 +28,7 @@ public CacheOptions CacheOptions
     /// </summary>
     public IFileLocator FileLocator
     {
-        init;
+        set;
         get
         {
             if (field is null)
@@ -53,15 +53,15 @@ public IFileLocator FileLocator
     /// resolution.</remarks>
     public string SymbolCachePath
     {
-        init;
+        set;
         get => field ??= Path.Combine(Path.GetTempPath(), "symbols");
     }
 
     /// <summary>
     /// The symbol path used by the default file locator if <see cref="FileLocator"/> is null.  If
     /// <see cref="FileLocator"/> is non-null, this property has no effect.
     /// </summary>
-    public string[] SymbolPaths { get; init; } = ["https://msdl.microsoft.com/download/symbols"];
+    public string[] SymbolPaths { get; set; } = ["https://msdl.microsoft.com/download/symbols"];
 
     /// <summary>
     /// If true, all runtimes in the target process will be enumerated.  This enables us to find single-file runtimes
@@ -73,15 +73,15 @@ public string SymbolCachePath
     /// <summary>
     /// The TokenCredential to use for any Azure based symbol servers (set to null if not using one).
     /// </summary>
-    public TokenCredential? SymbolTokenCredential { get; init; }
+    public TokenCredential? SymbolTokenCredential { get; set; }
 
     /// <summary>
     /// Gets or sets a value indicating whether detailed information about symbol requests is traced during execution.
     /// </summary>
     /// <remarks>When enabled, this property allows the tracing of all symbol resolution requests, which can
     /// be useful for debugging or analyzing symbol loading behavior. Tracing may produce a large amount of output and
     /// could impact performance.</remarks>
-    public bool TraceSymbolRequests { get; init; }
+    public bool TraceSymbolRequests { get; set; }
 
     /// <summary>
     /// Safety limits for parsing and enumeration operations. These limits prevent excessive memory
@@ -90,7 +90,7 @@ public string SymbolCachePath
     public DataTargetLimits Limits
     {
         get => field ??= new DataTargetLimits();
-        init;
+        set;
     }
 
     /// <summary>
@@ -99,15 +99,15 @@ public DataTargetLimits Limits
     /// from source).  This only affects dacs with a signature.
     /// Note that disabling this option can lead to security risks, so it should only be disabled if you understand the implications.
     /// </summary>
-    public bool VerifyDacOnWindows { get; init; } = true;
+    public bool VerifyDacOnWindows { get; set; } = true;
 
     /// <summary>
     /// An optional callback that decides, per DAC, whether ClrMD verifies its signature before loading it.
     /// When non-null this takes priority over <see cref="VerifyDacOnWindows"/>: it is invoked with the full
     /// (absolute) path of the DAC (or cDAC) ClrMD is about to load and if it returns <see langword="true"/>,
     /// signature verification is performed; if it returns <see langword="false"/>, verification is skipped.
     /// </summary>
-    public Func<string, bool>? DacSignatureVerificationOverride { get; init; }
+    public Func<string, bool>? DacSignatureVerificationOverride { get; set; }
 
     /// <summary>
     /// When true, <see cref="DataTarget.LoadDump(string, DataTargetOptions?)"/> will wrap the underlying
@@ -134,12 +134,12 @@ public DataTargetLimits Limits
     /// as a 64-bit process) when loading large dumps from a 32-bit host.
     /// </para>
     /// </summary>
-    public bool UseLockFreeMemoryMapReader { get; init; }
+    public bool UseLockFreeMemoryMapReader { get; set; }
 
     /// <summary>
     /// Optional host-supplied symbol provider. When set, ClrMD's COM data
     /// target wrapper exposes <c>ICLRSymbolProvider</c> and forwards its
     /// calls to this instance.
     /// </summary>
-    public IClrSymbolProvider? SymbolProvider { get; init; }
+    public IClrSymbolProvider? SymbolProvider { get; set; }
 }