Skip to content

Commit 6c56bbf

Browse files
authored
Merge pull request #318 from microsoft/fix-example-in-sql-injection
PS: Fix example in SQL injection documentation
2 parents 657686b + 1aec7fc commit 6c56bbf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

powershell/ql/src/queries/security/cwe-089/examples/SqlInjection.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ param(
44

55
# BAD: The user input is directly interpolated into the SQL query string
66
$query1 = "SELECT * FROM users WHERE name = '$userinput'"
7-
Invoke-Sqlcmd -ServerInstance "MyServer" -Database "MyDatabase" -Query $query
7+
Invoke-Sqlcmd -ServerInstance "MyServer" -Database "MyDatabase" -Query $query1
88

99
# GOOD: Using parameters to prevent SQL injection
1010
$query2 = "SELECT * FROM users WHERE name = @username"
@@ -13,4 +13,4 @@ $params = @{
1313
username = $userinput
1414
}
1515

16-
Invoke-Sqlcmd -ServerInstance "MyServer" -Database "MyDatabase" -Query $query -QueryParameters $params
16+
Invoke-Sqlcmd -ServerInstance "MyServer" -Database "MyDatabase" -Query $query2 -QueryParameters $params

0 commit comments

Comments
 (0)