Skip to content

Commit cf2c1bc

Browse files
Fix ConanComponent.PackageURL
1 parent a1025df commit cf2c1bc

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/Microsoft.ComponentDetection.Contracts/TypedComponent/ConanComponent.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public ConanComponent(string name, string version, string previous, string packa
2929

3030
public override ComponentType Type => ComponentType.Conan;
3131

32-
public override PackageURL PackageUrl => new PackageURL("conan", string.Empty, this.Name, this.Version, null, string.Empty);
32+
public override PackageURL PackageUrl => new PackageURL("conan", null, this.Name, this.Version, null, null);
3333

3434
protected override string ComputeId() => $"{this.Name} {this.Version} - {this.Type}";
3535
}

test/Microsoft.ComponentDetection.Contracts.Tests/PurlGenerationTests.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,15 @@ public void CocoaPodNameShouldPurlWithCustomQualifier()
109109

110110
packageOne.PackageUrl.ToString().Should().Be("pkg:cocoapods/[email protected]?repository_url=https://custom_repo.example.com/path/to/repo/specs.git");
111111
}
112+
113+
[TestMethod]
114+
public void ConanShouldSupportPurl()
115+
{
116+
// https://github.com/package-url/purl-spec/blob/main/PURL-TYPES.rst#conan
117+
var packageOne = new ConanComponent("openssl", "3.4.1", "afcaa66ae3020340af2d5641a475b5ae", "80626e45106f252f73093b8b9376039358185fb4");
118+
119+
packageOne.PackageUrl.Type.Should().Be("conan");
120+
packageOne.PackageUrl.Name.Should().Be("openssl");
121+
packageOne.PackageUrl.ToString().Should().Be("pkg:conan/[email protected]");
122+
}
112123
}

0 commit comments

Comments
 (0)