Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan link dependencies with the Pnpm detector #130

Open
jcfiorenzano opened this issue Jun 17, 2022 · 0 comments
Open

Scan link dependencies with the Pnpm detector #130

jcfiorenzano opened this issue Jun 17, 2022 · 0 comments
Labels
detector:pnpm The pnpm detector status:ready Ready to start implementation type:feature Feature (new functionality)

Comments

@jcfiorenzano
Copy link
Contributor

The pnpm-lock.ymal file can have entries that refer to modules that are present in the file system ex:

  /query-string/4.3.4:
    dependencies:
      '@learningclient/common': link:../common

Resolving this path should take us to a folder with a package.json file. We could parse this file to get the version of the component.
Today the component is not registered by the PnpmDetector but by the NpmDetector. This is a little inconvenient because the NpmDetector cannot create a dependency graph for this component and does not have information if the component is a dev dependency or not.

@jcfiorenzano jcfiorenzano added the detector:pnpm The pnpm detector label Jun 17, 2022
@cobya cobya added type:feature Feature (new functionality) status:ready Ready to start implementation labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:pnpm The pnpm detector status:ready Ready to start implementation type:feature Feature (new functionality)
Projects
Development

No branches or pull requests

2 participants