Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: only detect NPM modules under node_modules directory #190

Open
JasonYeMSFT opened this issue Aug 8, 2022 · 0 comments
Open
Labels
detector:npm The npm detector status:requirements Full requirements are not yet known, so implementation should not be started

Comments

@JasonYeMSFT
Copy link

For example, if I have a project using an NPM module called my-module with the following file structure:

  • node_modules/
    • my-module
      • package.json
      • src/
        • index.js
        • package.json

Only my-module should be detected as a dependency. I would expect the 2nd package.json to be treated as an arbitrary source file of my-module. I have a build task using this project to detect dependencies and it is constantly emitting warnings about a test file which happens to be named package.json.

@JasonYeMSFT JasonYeMSFT changed the title Suggestion: only detect NPM packages under node_modules directory Suggestion: only detect NPM modules under node_modules directory Aug 8, 2022
@JamieMagee JamieMagee added status:requirements Full requirements are not yet known, so implementation should not be started detector:npm The npm detector labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:npm The npm detector status:requirements Full requirements are not yet known, so implementation should not be started
Projects
None yet
Development

No branches or pull requests

2 participants