Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Poetry detector tests #304

Open
JamieMagee opened this issue Oct 17, 2022 · 0 comments
Open

Review Poetry detector tests #304

JamieMagee opened this issue Oct 17, 2022 · 0 comments
Labels
detector:poetry The poetry detector status:ready Ready to start implementation type:bug Bug fix of existing functionality

Comments

@JamieMagee
Copy link
Member

In #184 and #230 we migrated from Nett to Tomlyn as our TOML parsing library as Nett was unsupported and deprecated. We used the IgnoreMissingProperties option to allow us to parse poetry.lock files which are missing properties defined in our PoetryLock model. Unfortunately, this property was not being respected for objects, like metadata.

This issue was fixed in xoofx/Tomlyn#44, and upgrading to Tomlyn version 0.15.1 should resolve the issue. However, this should have been caught by our unit tests.

This issue is created to followup on why this was not caught by our tests cases.

See #301 for more context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
detector:poetry The poetry detector status:ready Ready to start implementation type:bug Bug fix of existing functionality
Projects
Component Detection - Library Improvements
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamieMagee