Skip to content

Commit 6d87134

Browse files
authored
Naming adjustments (#707)
## Motivation and Context (Why the change? What's the scenario?) Rename class and method parameters to match the overall naming convention. See #705 and #706.
1 parent ed95532 commit 6d87134

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

examples/110-dotnet-anthropic/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
using Microsoft.KernelMemory.DocumentStorage.DevTools;
66
using Microsoft.KernelMemory.MemoryStorage.DevTools;
77

8-
var anthropicConfig = new AnthropicConfiguration();
8+
var anthropicConfig = new AnthropicConfig();
99
var azureOpenAIEmbeddingConfig = new AzureOpenAIConfig();
1010

1111
new ConfigurationBuilder()

extensions/Anthropic/AnthropicConfiguration.cs renamed to extensions/Anthropic/AnthropicConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Microsoft.KernelMemory.AI.Anthropic;
77
/// <summary>
88
/// Configuration for Text Generation with Anthropic
99
/// </summary>
10-
public class AnthropicConfiguration
10+
public class AnthropicConfig
1111
{
1212
/// <summary>
1313
/// Anthropic web service endpoint

extensions/Anthropic/AnthropicTextGeneration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public sealed class AnthropicTextGeneration : ITextGenerator, IDisposable
3636
/// <param name="httpClientFactory">Optional factory used to inject a pre-configured HTTP client for requests to Anthropic API</param>
3737
/// <param name="loggerFactory">Optional factory used to inject configured loggers</param>
3838
public AnthropicTextGeneration(
39-
AnthropicConfiguration config,
39+
AnthropicConfig config,
4040
ITextTokenizer? textTokenizer = null,
4141
IHttpClientFactory? httpClientFactory = null,
4242
ILoggerFactory? loggerFactory = null)

extensions/Anthropic/DependencyInjection.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public static partial class KernelMemoryBuilderExtensions
2323
/// <param name="textTokenizer">Optional tokenizer, default one will be used if passed null.</param>
2424
public static IKernelMemoryBuilder WithAnthropicTextGeneration(
2525
this IKernelMemoryBuilder builder,
26-
AnthropicConfiguration config,
26+
AnthropicConfig config,
2727
ITextTokenizer? textTokenizer = null)
2828
{
2929
builder.Services.AddAnthropicTextGeneration(config, textTokenizer);
@@ -44,7 +44,7 @@ public static partial class DependencyInjection
4444
/// <param name="textTokenizer">Tokenizer to measure content size</param>
4545
public static IServiceCollection AddAnthropicTextGeneration(
4646
this IServiceCollection services,
47-
AnthropicConfiguration config,
47+
AnthropicConfig config,
4848
ITextTokenizer? textTokenizer = null)
4949
{
5050
services.AddSingleton(config);

service/Core/SemanticKernel/KernelMemoryBuilderExtensions.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@ public static partial class KernelMemoryBuilderExtensions
2222
/// <param name="builder">KM builder</param>
2323
/// <param name="service">SK text generation service instance</param>
2424
/// <param name="config">SK text generator settings</param>
25-
/// <param name="tokenizer">Tokenizer used to count tokens used by prompts</param>
25+
/// <param name="textTokenizer">Tokenizer used to count tokens used by prompts</param>
2626
/// <param name="loggerFactory">.NET logger factory</param>
2727
/// <returns>KM builder</returns>
2828
public static IKernelMemoryBuilder WithSemanticKernelTextGenerationService(
2929
this IKernelMemoryBuilder builder,
3030
ITextGenerationService service,
3131
SemanticKernelConfig config,
32-
ITextTokenizer? tokenizer = null,
32+
ITextTokenizer? textTokenizer = null,
3333
ILoggerFactory? loggerFactory = null)
3434
{
3535
if (service == null) { throw new ConfigurationException("Memory Builder: the semantic kernel text generation service instance is NULL"); }
3636

37-
return builder.AddSingleton<ITextGenerator>(new SemanticKernelTextGenerator(service, config, tokenizer, loggerFactory));
37+
return builder.AddSingleton<ITextGenerator>(new SemanticKernelTextGenerator(service, config, textTokenizer, loggerFactory));
3838
}
3939

4040
/// <summary>
@@ -44,21 +44,21 @@ public static IKernelMemoryBuilder WithSemanticKernelTextGenerationService(
4444
/// <param name="builder">KM builder</param>
4545
/// <param name="service">SK text embedding generation instance</param>
4646
/// <param name="config">SK text embedding generator settings</param>
47-
/// <param name="tokenizer">Tokenizer used to count tokens sent to the embedding generator</param>
47+
/// <param name="textTokenizer">Tokenizer used to count tokens sent to the embedding generator</param>
4848
/// <param name="loggerFactory">.NET logger factory</param>
4949
/// <param name="onlyForRetrieval">Whether to use this embedding generator only during data ingestion, and not for retrieval (search and ask API)</param>
5050
/// <returns>KM builder</returns>
5151
public static IKernelMemoryBuilder WithSemanticKernelTextEmbeddingGenerationService(
5252
this IKernelMemoryBuilder builder,
5353
ITextEmbeddingGenerationService service,
5454
SemanticKernelConfig config,
55-
ITextTokenizer? tokenizer = null,
55+
ITextTokenizer? textTokenizer = null,
5656
ILoggerFactory? loggerFactory = null,
5757
bool onlyForRetrieval = false)
5858
{
5959
if (service == null) { throw new ConfigurationException("Memory Builder: the semantic kernel text embedding generation service instance is NULL"); }
6060

61-
var generator = new SemanticKernelTextEmbeddingGenerator(service, config, tokenizer, loggerFactory);
61+
var generator = new SemanticKernelTextEmbeddingGenerator(service, config, textTokenizer, loggerFactory);
6262
builder.AddSingleton<ITextEmbeddingGenerator>(generator);
6363

6464
if (!onlyForRetrieval)

service/Service/ServiceConfiguration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ private void ConfigureTextGenerator(IKernelMemoryBuilder builder)
420420
break;
421421

422422
case string x when x.Equals("Anthropic", StringComparison.OrdinalIgnoreCase):
423-
builder.Services.AddAnthropicTextGeneration(this.GetServiceConfig<AnthropicConfiguration>("Anthropic"));
423+
builder.Services.AddAnthropicTextGeneration(this.GetServiceConfig<AnthropicConfig>("Anthropic"));
424424
break;
425425

426426
case string x when x.Equals("LlamaSharp", StringComparison.OrdinalIgnoreCase):

0 commit comments

Comments
 (0)