Nested classes

[akordowski]

Working with the KM I have seen that there are cases where nested classes are used as property types, eg DocumentUploadRequest.UploadedFile:

var request = new DocumentUploadRequest
{
    Files = [new DocumentUploadRequest.UploadedFile(fileName, fileContent)],
    ...
};

As this is very unusual regarding the overall library design, I was wondering if there is any architectural reason for this? IMO it's harder to find the type and breaks the developer expirience.

[dluc]

This design preference is used when nested types are only relevant within the enclosing class and should not be reused externally. The container class acts as a namespace. Nested classes often have generic or duplicate names, and placing them outside would make it harder to distinguish them from globally used classes.

[akordowski]

This design preference is used when nested types are only relevant within the enclosing class and should not be reused externally.

Thank you for the explanation. Interesting aspect, I've never seen it like this.

[akordowski]

As the function is called ImportDocumentAsync maybe the name DocumentImportRequest.DocumentFile would be clearer? What do you think?