Should (4xx-5xx) exceptions from Kiota follow dotnet naming convention

[thoekstraorama]

We are using problem details in our aspnetcore project and are generating clients for our API's with Kiota. Recently I got some feedback of a colleague. He told me that he wasn't sure whether the ProblemDetails thrown by the kiota generated client was an exception or not. This was because of the lack of the 'Exception'-suffix.

So my question is. Shouldn't exceptions thrown by Kiota follow the dotnet naming conventions? This would not only help by showing properly that it's an exception thrown by the client, it will help by making the differentiation between 'ProblemDetails' from aspnetcore and 'ProblemDetailsException' thrown by a kiota generated client.

I understand that this will break a lot of generated applications. So if this is something that is interesting it should probably be a opt-in.

Example for clarity:

        try
        {
            return await _apiClient.Api.V1.Entities[id].GetAsync(cancellationToken: cancellationToken);
        }
        catch (ProblemDetails problemDetails)
        {
            if (problemDetails.ResponseStatusCode == (int)HttpStatusCode.NotFound)
            {
                _logger.LogWarning(problemDetails, "Entity does not exist");
                return null;
            }
            throw;
        }

[baywet]

Hi @thoekstraorama
Thank you for using kiota and for reaching out.

This is a great suggestion, but yes, it'd be a source breaking change for existing clients.
Also, I'm a bit worried that it'd give "confusing" names in some scenarios. E.g. something containing error "FooErrorException".
Let us know if you have any additional comments or questions.