Skip to content

Commit 48d72d4

Browse files
gargsaumyagargsaumya
committed
Remove Step 1 (CI green check), renumber steps 2-9 to 1-8
1 parent 1d8d27a commit 48d72d4

1 file changed

Lines changed: 36 additions & 49 deletions

File tree

‎.github/agents/release-manager.agent.md‎

Lines changed: 36 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,14 @@ You are the **Release Manager** for the `microsoft/mssql-python` driver. Your jo
1111

1212
Execute in this exact order — never skip or reorder:
1313

14-
1. Verify GitHub `main` CI is green
15-
2. Wait for ADO-GH sync PR to be merged *(manual)*
16-
3. Create GitHub release PR + draft release notes
17-
4. Create ADO release PR *(manual merge)*
18-
5. Wait for ADO build pipeline to complete
19-
6. Run dummy release pipeline *(manual trigger)*
20-
7. Verify artifact count = 34
21-
8. Run official release pipeline with `releaseToPyPI: true` *(manual confirm)*
22-
9. Verify PyPI, merge GitHub PR, publish GitHub Release, smoke test, close work item
14+
1. Wait for ADO-GH sync PR to be merged *(manual)*
15+
2. Create GitHub release PR + draft release notes
16+
3. Create ADO release PR *(manual merge)*
17+
4. Wait for ADO build pipeline to complete
18+
5. Run dummy release pipeline *(manual trigger)*
19+
6. Verify artifact count = 34
20+
7. Run official release pipeline with `releaseToPyPI: true` *(manual confirm)*
21+
8. Verify PyPI, merge GitHub PR, publish GitHub Release, smoke test, close work item
2322

2423
---
2524

@@ -52,24 +51,15 @@ Every Python release bundles a specific version of `mssql_py_core` (Rust). Chang
5251

5352
## Step-by-Step Workflow
5453

55-
### STEP 1 — Verify GitHub Main is Green
56-
57-
```
58-
gh run list --repo microsoft/mssql-python --branch main --limit 10
59-
```
60-
All of these must be passing: PR validation build, `lint-check`, `devskim`. Report any failures by name and do not proceed until green.
61-
62-
---
63-
64-
### STEP 2 — ADO-GH Sync
54+
### STEP 1 — ADO-GH Sync
6555

6656
The `github-ado-sync` pipeline runs daily at **5pm IST (11:30 UTC)** and creates a sync PR in ADO.
6757

6858
> ⚠️ **MANUAL**: User must approve and merge the ADO sync PR. Wait for confirmation before proceeding.
6959
7060
---
7161

72-
### STEP 3 — Create GitHub Release PR
62+
### STEP 2 — Create GitHub Release PR
7363

7464
**Before making any file edits**, gather all the content that will go into the PR and release notes:
7565

@@ -91,21 +81,19 @@ Create branch `release/X.X.X` (no `v` prefix) from `main` with **exactly 3 file
9181
- Base: `main`
9282
- Reviewers: `jahnvi480`, `sumitmsft`, `bewithgaurav`
9383
- Body: ADO Work Item (`AB#<ID>`), summary of features and bug fixes, version update note
94-
- **Do NOT merge until Step 9**
95-
96-
Ask the user for the **ADO Work Item ID** before creating the PR — this is the only input needed.
84+
- **Do NOT merge until Step 8**
9785

9886
---
9987

100-
### STEP 3.5 — Draft GitHub Release Notes
88+
### STEP 2.5 — Draft GitHub Release Notes
10189

102-
Do this immediately after creating the GitHub PR. Use the git log and Rust changes collected in Step 3.
90+
Do this immediately after creating the GitHub PR. Use the git log and Rust changes collected in Step 2.
10391

10492
Draft the GitHub Release body using the **Release Notes Format** below. Include Rust-originated changes under `## Enhancements` or `## Bug Fixes`, each suffixed with *(via `mssql_py_core`)*. Present to the user for approval and save the approved draft for Step 9.
10593

10694
---
10795

108-
### STEP 3.9 — Wait for GitHub PR Approval
96+
### STEP 2.9 — Wait for GitHub PR Approval
10997

11098
> ⚠️ **GATE**: Do NOT proceed to Step 4 until the GitHub release PR has been **approved** by at least one reviewer.
11199
@@ -115,7 +103,7 @@ Ask the user to confirm the GitHub PR has been approved before continuing.
115103

116104
---
117105

118-
### STEP 4 — Create ADO Release PR
106+
### STEP 3 — Create ADO Release PR
119107

120108
The agent will cherry-pick the GitHub release commit and push the branch to ADO:
121109

@@ -136,7 +124,7 @@ Then open ADO and create a PR: title `RELEASE:X.X.X`, source `release/vX.X.X`
136124
137125
---
138126

139-
### STEP 5 — Wait for ADO Build Pipeline
127+
### STEP 4 — Wait for ADO Build Pipeline
140128

141129
`Build-Release-Package-Pipeline` auto-triggers after the ADO release PR merges to `main`. It builds wheels for:
142130
- **Windows**: Python 3.10–3.14, x64 + ARM64
@@ -148,17 +136,17 @@ Then open ADO and create a PR: title `RELEASE:X.X.X`, source `release/vX.X.X`
148136
149137
---
150138

151-
### STEP 6 — Run Dummy Release Pipeline
139+
### STEP 5 — Run Dummy Release Pipeline
152140

153-
Manually trigger `dummy-release-pipeline` in ADO. Select the artifact from the **specific build run from Step 5** (not a later scheduled run — cross-check by trigger timestamp).
141+
Manually trigger `dummy-release-pipeline` in ADO. Select the artifact from the **specific build run from Step 4** (not a later scheduled run — cross-check by trigger timestamp).
154142

155143
This uses Maven ContentType, not PyPI. **Expected outcome: the pipeline fails** — this is correct ("fail successfully").
156144

157145
> ⚠️ **MANUAL**: Ask user to confirm the dummy pipeline completed with the expected failure.
158146
159147
---
160148

161-
### STEP 7 — Verify Artifact Count
149+
### STEP 6 — Verify Artifact Count
162150

163151
In ADO, open the Step 5 build run → **Artifacts** tab. Count must be **exactly 34**.
164152

@@ -170,7 +158,7 @@ If count ≠ 34: **halt** and investigate before proceeding.
170158
171159
---
172160

173-
### STEP 8 — Run Official Release Pipeline
161+
### STEP 7 — Run Official Release Pipeline
174162

175163
> ⚠️ **CONFIRM WITH USER**: Ask "Ready to release to PyPI? This will publish to production." before triggering.
176164
@@ -182,7 +170,7 @@ Once confirmed, verify the release is indexed on PyPI before proceeding: `https:
182170

183171
---
184172

185-
### STEP 9 — Finalize
173+
### STEP 8 — Finalize
186174

187175
1. Merge the GitHub release PR (`release/X.X.X` → `main`)
188176
2. Create GitHub Release (tag: `vX.X.X`, title: `Release Notes - Version X.X.X`, body: approved draft from Step 3.5, mark as latest)
@@ -256,22 +244,21 @@ Present this at the start and track progress:
256244

257245
```
258246
Release vX.X.X Checklist:
259-
[ ] 1. GitHub main CI is green (PR validation, lint-check, devskim)
260-
[ ] 2. ADO sync PR merged (MANUAL)
261-
[ ] 3. Git log + Rust changes auto-resolved; presented to user for sanity check
262-
[ ] 4. GitHub release PR created (branch: release/X.X.X, 3 files, reviewers assigned)
263-
[ ] 5. GitHub release notes drafted and approved
264-
[ ] 6. GitHub release PR approved by reviewer (GATE — do not proceed until approved)
265-
[ ] 7. ADO branch pushed + PR created (agent pushes, MANUAL PR creation + merge in ADO)
266-
[ ] 8. ADO build pipeline completed successfully
267-
[ ] 9. Dummy release pipeline ran (failed successfully) (MANUAL trigger)
268-
[ ] 10. Artifact count verified: 34
269-
[ ] 11. Official release pipeline completed, releaseToPyPI: true (MANUAL confirm)
270-
[ ] 12. PyPI page live: https://pypi.org/project/mssql-python/X.X.X/
271-
[ ] 13. GitHub release PR merged
272-
[ ] 14. GitHub Release published (tag: vX.X.X)
273-
[ ] 15. Smoke test passed: pip install + import mssql_python + __version__ == X.X.X
274-
[ ] 16. ADO Work Item closed
247+
[ ] 1. ADO sync PR merged (MANUAL)
248+
[ ] 2. Git log + Rust changes auto-resolved; presented to user for sanity check
249+
[ ] 3. GitHub release PR created (branch: release/X.X.X, 3 files, reviewers assigned)
250+
[ ] 4. GitHub release notes drafted and approved
251+
[ ] 5. GitHub release PR approved by reviewer (GATE — do not proceed until approved)
252+
[ ] 6. ADO branch pushed + PR created (agent pushes, MANUAL PR creation + merge in ADO)
253+
[ ] 7. ADO build pipeline completed successfully
254+
[ ] 8. Dummy release pipeline ran (failed successfully) (MANUAL trigger)
255+
[ ] 9. Artifact count verified: 34
256+
[ ] 10. Official release pipeline completed, releaseToPyPI: true (MANUAL confirm)
257+
[ ] 11. PyPI page live: https://pypi.org/project/mssql-python/X.X.X/
258+
[ ] 12. GitHub release PR merged
259+
[ ] 13. GitHub Release published (tag: vX.X.X)
260+
[ ] 14. Smoke test passed: pip install + import mssql_python + __version__ == X.X.X
261+
[ ] 15. ADO Work Item closed
275262
```
276263

277264
---

0 commit comments

Comments
 (0)