Merged PR 7400: Sync development to main

Sync of development to main branch.

Before merging this PR, ensure that the CI has had a good run on the development branch.

Author: mssql-rs Build Service (SqlClientDrivers)

.pipeline/sync-container-images.yml

@@ -118,7 +118,7 @@ stages:
     steps:
     - checkout: none
     - task: AzureCLI@2
-      displayName: 'Import manylinux x64'
+      displayName: 'Import manylinux_2_34 x64'
       inputs:
         azureSubscription: 'Magnitude Test'
         scriptType: 'bash'
@@ -131,7 +131,7 @@ stages:
             --force
       retryCountOnTaskFailure: 3
     - task: AzureCLI@2
-      displayName: 'Import manylinux arm64'
+      displayName: 'Import manylinux_2_34 arm64'
       inputs:
         azureSubscription: 'Magnitude Test'
         scriptType: 'bash'
@@ -143,6 +143,32 @@ stages:
             --image import/python-build/manylinux_2_34_aarch64:latest \
             --force
       retryCountOnTaskFailure: 3
+    - task: AzureCLI@2
+      displayName: 'Import manylinux_2_28 x64'
+      inputs:
+        azureSubscription: 'Magnitude Test'
+        scriptType: 'bash'
+        scriptLocation: 'inlineScript'
+        inlineScript: |
+          az acr import \
+            --name $(ACR_NAME) \
+            --source quay.io/pypa/manylinux_2_28_x86_64:latest \
+            --image import/python-build/manylinux_2_28_x86_64:latest \
+            --force
+      retryCountOnTaskFailure: 3
+    - task: AzureCLI@2
+      displayName: 'Import manylinux_2_28 arm64'
+      inputs:
+        azureSubscription: 'Magnitude Test'
+        scriptType: 'bash'
+        scriptLocation: 'inlineScript'
+        inlineScript: |
+          az acr import \
+            --name $(ACR_NAME) \
+            --source quay.io/pypa/manylinux_2_28_aarch64:latest \
+            --image import/python-build/manylinux_2_28_aarch64:latest \
+            --force
+      retryCountOnTaskFailure: 3
 
 # -----------------------------------------------------------------------------
 # Sync Stage 2: PyPA musllinux images (quay.io - no Docker Hub rate limit)
@@ -821,7 +847,7 @@ stages:
           echo "======================================================"
           echo "Vanilla PyPA Base Images:"
           echo "======================================================"
-          for image in import/python-build/manylinux_2_34_x86_64 import/python-build/manylinux_2_34_aarch64 import/python-build/musllinux_1_2_x86_64 import/python-build/musllinux_1_2_aarch64; do
+          for image in import/python-build/manylinux_2_34_x86_64 import/python-build/manylinux_2_34_aarch64 import/python-build/manylinux_2_28_x86_64 import/python-build/manylinux_2_28_aarch64 import/python-build/musllinux_1_2_x86_64 import/python-build/musllinux_1_2_aarch64; do
             echo ""
             echo "==> $image"
             az acr repository show-tags --name $(ACR_NAME) --repository $image --output table --orderby time_desc --top 3 || echo "  (not found)"
@@ -871,10 +897,12 @@ stages:
         echo ""
         echo "Available images in ACR:"
         echo "  Vanilla PyPA base images:"
-        echo "    - $(ACR_REGISTRY)/python-build/manylinux_2_34_x86_64:latest"
-        echo "    - $(ACR_REGISTRY)/python-build/manylinux_2_34_aarch64:latest"
-        echo "    - $(ACR_REGISTRY)/python-build/musllinux_1_2_x86_64:latest"
-        echo "    - $(ACR_REGISTRY)/python-build/musllinux_1_2_aarch64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/manylinux_2_34_x86_64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/manylinux_2_34_aarch64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/manylinux_2_28_x86_64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/manylinux_2_28_aarch64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/musllinux_1_2_x86_64:latest"
+        echo "    - $(ACR_REGISTRY)/import/python-build/musllinux_1_2_aarch64:latest"
         echo ""
         echo "  Custom images with Rust (RECOMMENDED FOR CI/CD):"
         echo "    - $(ACR_REGISTRY)/python-build/manylinux_2_34_x86_64_rust:latest"

.pipeline/templates/build-template.yml

@@ -36,6 +36,16 @@ parameters:
   type: boolean
   default: true
 
+- name: enableRustBuild
+  displayName: Enable standalone Rust Debug/Release build steps
+  type: boolean
+  default: true
+
+- name: enableClippy
+  displayName: Enable Rust Clippy lint step
+  type: boolean
+  default: true
+
 steps:
 - template: generate-sql-password-template.yml
   parameters:
@@ -44,22 +54,23 @@ steps:
 - script: cargo fetch
   displayName: Fetch Crates
 
-- script: |
-    cargo build --frozen 2>&1
-  displayName: Rust Debug Build
-  condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Debug'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
+- ${{ if eq(parameters.enableRustBuild, true) }}:
+  - script: |
+      cargo build --frozen 2>&1
+    displayName: Rust Debug Build
+    condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Debug'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
 
-- script: |
-    cargo build --frozen --release 2>&1
-  displayName: Rust Release Build
-  condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
+  - script: |
+      cargo build --frozen --release 2>&1
+    displayName: Rust Release Build
+    condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
 
-- ${{ if eq(parameters.osType, 'Windows') }}:
+- ${{ if and(eq(parameters.enableClippy, true), eq(parameters.osType, 'Windows')) }}:
   - pwsh: ./scripts/bclippy.ps1
     displayName: Rust Clippy Lint (workspace + mssql-py-core)
     condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
 
-- ${{ if ne(parameters.osType, 'Windows') }}:
+- ${{ if and(eq(parameters.enableClippy, true), ne(parameters.osType, 'Windows')) }}:
   - script: ./scripts/bclippy.sh
     displayName: Rust Clippy Lint (workspace + mssql-py-core)
     condition: and(succeeded(), or(eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')), eq(variables['Build.Reason'], 'PullRequest'))
@@ -164,25 +175,26 @@ steps:
         summaryFileLocation: "$(Build.SourcesDirectory)/target/lcov.info"
         pathToSources: "$(Build.SourcesDirectory)"
 
-- task: CopyFiles@2
-  displayName: Copy Rust Debug Build
-  condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'),  or(eq('${{parameters.buildType}}', 'Debug'), eq('${{parameters.buildType}}', 'Both')))
-  inputs:
-    SourceFolder: '$(CARGO_TARGET_DIR)/debug'
-    Contents: |
-      *
-      !.cargo-lock
-    TargetFolder: '$(Build.ArtifactStagingDirectory)/debug'
-
-- task: CopyFiles@2
-  displayName: Copy Rust Release Build
-  condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'), or( eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')))
-  inputs:
-    SourceFolder: '$(CARGO_TARGET_DIR)/release'
-    Contents: |
-      *
-      !.cargo-lock
-    TargetFolder: '$(Build.ArtifactStagingDirectory)/release'
+- ${{ if eq(parameters.enableRustBuild, true) }}:
+  - task: CopyFiles@2
+    displayName: Copy Rust Debug Build
+    condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'),  or(eq('${{parameters.buildType}}', 'Debug'), eq('${{parameters.buildType}}', 'Both')))
+    inputs:
+      SourceFolder: '$(CARGO_TARGET_DIR)/debug'
+      Contents: |
+        *
+        !.cargo-lock
+      TargetFolder: '$(Build.ArtifactStagingDirectory)/debug'
+
+  - task: CopyFiles@2
+    displayName: Copy Rust Release Build
+    condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'), or( eq('${{parameters.buildType}}', 'Release'), eq('${{parameters.buildType}}', 'Both')))
+    inputs:
+      SourceFolder: '$(CARGO_TARGET_DIR)/release'
+      Contents: |
+        *
+        !.cargo-lock
+      TargetFolder: '$(Build.ArtifactStagingDirectory)/release'
 
 - ${{ if eq(parameters.enableJsBuild, true) }}:
   - bash: |

.pipeline/templates/test-mssql-python-template.yml

@@ -133,21 +133,14 @@ steps:
         set -e
         update-ca-certificates
         source ~/.cargo/env
-        
-        # Install Python 3.12 via deadsnakes PPA
-        apt-get update
-        apt-get install -y software-properties-common
-        add-apt-repository -y ppa:deadsnakes/ppa
-        apt-get update
-        apt-get install -y python3.12 python3.12-venv python3.12-dev
-        
-        # Create Python 3.12 venv and install deps
-        python3.12 -m venv /tmp/py312-venv
-        source /tmp/py312-venv/bin/activate
+
+        # Use the build image'"'"'s pre-installed Python 3.10 (mssql-python requires >=3.10).
+        # No PPA install — avoids dependency on Launchpad availability.
+        python3 -m venv /tmp/py-venv
+        source /tmp/py-venv/bin/activate
         pip install --upgrade pip -q
         pip install maturin pytest pytest-asyncio python-dotenv patchelf pybind11 wheel setuptools -q
-        
-        # Run the test script
+
         ./dev/test-python.sh --mssql-python
       '
   displayName: Build bindings and run mssql-python tests
@@ -168,45 +161,39 @@ steps:
       $BUILD_IMAGE \
       bash -c '
         set -e
-        
-        # Install Python 3.12
-        apt-get update
-        apt-get install -y software-properties-common
-        add-apt-repository -y ppa:deadsnakes/ppa
-        apt-get update
-        apt-get install -y python3.12 python3.12-venv
-        
-        # Setup Python 3.12 venv
-        python3.12 -m venv /tmp/wheel-venv
+
+        # Use the build image'"'"'s pre-installed Python 3.10 (mssql-python requires >=3.10).
+        # No PPA install — avoids dependency on Launchpad availability.
+        python3 -m venv /tmp/wheel-venv
         source /tmp/wheel-venv/bin/activate
         pip install --upgrade pip -q
         pip install wheel setuptools -q
-        
+
         # Verify both .so files exist (from test-python.sh)
         echo "Verifying bindings from test step..."
         ls -la mssql_python/*.so
-        
+
         # Create combined artifact folder
         mkdir -p /workspace/mssql-python-artifacts
-        
+
         # Copy mssql_py_core.so standalone for plug-n-play
         cp mssql_python/mssql_py_core*.so /workspace/mssql-python-artifacts/
-        
+
         # Extract mssql_py_core from NuGet (sets up mssql_py_core/ directory
         # with __init__.py and native extension required by setup.py validation)
         bash eng/scripts/install-mssql-py-core.sh
-        
+
         # Overwrite with freshly built .so from test step
         cp mssql_python/mssql_py_core*.so mssql_py_core/
-        
+
         # Build mssql-python wheel
         echo "Building mssql-python wheel..."
         rm -rf dist/ build/ *.egg-info
         python setup.py bdist_wheel
-        
+
         # Copy wheel to artifact folder
         cp dist/*.whl /workspace/mssql-python-artifacts/
-        
+
         echo "Artifacts:"
         ls -la /workspace/mssql-python-artifacts/
       '

.pipeline/validation-pipeline.yml

@@ -218,6 +218,8 @@ stages:
           osType: MacOS
           buildType: ${{ parameters.buildType }}
           testFilter: -E 'not (test(connectivity))'
+          enableRustBuild: false
+          enableClippy: false
 
 # Kerberos tests for PRs (fast - 2 distros: ubuntu22 + alpine318)
 - stage: Kerberos_Test_PR

Cargo.toml

@@ -3,6 +3,61 @@ resolver = "2"
 members = ["mssql-tds", "mssql-js", "mssql-tds-cli", "mssql-mock-tds"]
 exclude = ["mssql-py-core", "mssql-mock-tds-py"]
 
+[workspace.lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)', 'cfg(feature, values("sspi", "gssapi", "integrated-auth"))'] }
+
+[workspace.lints.clippy]
+# Don't Panic - prevent panics from unwraps and unsafe slicing or indexing
+# string_slice = "warn"
+# indexing_slicing = "warn"
+# unwrap_used = "warn"
+# panic = "warn"
+# todo = "warn"
+# unimplemented = "warn"
+# unreachable = "warn"
+# get_unwrap = "warn"
+# unwrap_in_result = "warn"
+# unchecked_time_subtraction = "warn"
+# panic_in_result_fn = "warn"
+
+# Don't Fail Silently - prevent dropped futures and swallowed errors
+# let_underscore_future = "warn"
+# let_underscore_must_use = "warn"
+# unused_result_ok = "warn"
+# map_err_ignore = "warn"
+# assertions_on_result_states = "warn"
+
+# Don't Do Bad Async Stuff - prevent deadlocks and concurrency bugs
+await_holding_lock = "warn"
+await_holding_refcell_ref = "warn"
+large_futures = "warn"
+
+# Don't Do Unsafe Things with Memory
+# mem_forget = "warn"
+# undocumented_unsafe_blocks = "warn"
+# multiple_unsafe_ops_per_block = "warn"
+# unnecessary_safety_doc = "warn"
+# unnecessary_safety_comment = "warn"
+
+# Don't Do Potentially Incorrect Things with Numbers
+# float_cmp = "warn"
+# float_cmp_const = "warn"
+# lossy_float_literal = "warn"
+# cast_sign_loss = "warn"
+# invalid_upcast_comparisons = "warn"
+
+# Don't Do Bad Things That are Easy to Avoid
+# rc_mutex = "warn"
+# debug_assert_with_mut_call = "warn"
+# iter_not_returning_iterator = "warn"
+# expl_impl_clone_on_copy = "warn"
+# infallible_try_from = "warn"
+# dbg_macro = "warn"
+
+# Don't `allow` Your Way Around These Lints
+# allow_attributes = "warn"
+# allow_attributes_without_reason = "warn"
+
 [profile.release]
 lto = true
 strip = "symbols"