chore: cleanup some things (#41896)

Author: dgozman

.github/workflows/roll_browser_into_playwright.yml

@@ -512,8 +512,6 @@ export class BidiBrowserContext extends BrowserContext {
     await Promise.all(promises);
   }
 
-  onClosePersistent() {}
-
   override async clearCache(): Promise<void> {
   }
 

packages/playwright-core/src/server/bidi/bidiBrowser.ts

@@ -271,8 +271,6 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdk
     this._closedStatus = 'closed';
     this._clientCertificatesProxy?.close().catch(() => {});
     this.tracing.abort();
-    if (this._isPersistentContext)
-      this.onClosePersistent();
     this._closePromiseFulfill!(new Error('Context closed'));
     this.emit(BrowserContext.Events.Close);
   }
@@ -303,7 +301,6 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdk
   protected abstract doUpdateDefaultEmulatedMedia(): Promise<void>;
   protected abstract doExposePlaywrightBinding(): Promise<void>;
   protected abstract doClose(reason: string | undefined): Promise<void | 'close-browser'>;
-  protected abstract onClosePersistent(): void;
 
   async cookies(progress: Progress, urls: string | string[] | undefined = []): Promise<channels.NetworkCookie[]> {
     return await progress.race(this._cookies(urls));

packages/playwright-core/src/server/browserContext.ts

@@ -576,9 +576,6 @@ export class CRBrowserContext extends BrowserContext<CREventsMap> {
     }
   }
 
-  onClosePersistent() {
-  }
-
   override async clearCache(): Promise<void> {
     for (const page of this._crPages())
       await page._networkManager.clearCache();

packages/playwright-core/src/server/chromium/crBrowser.ts

@@ -392,8 +392,6 @@ export class FFBrowserContext extends BrowserContext {
     this._browser.session.send('Browser.addBinding', { browserContextId: this._browserContextId, name: PageBinding.kBindingName, script: '' });
   }
 
-  onClosePersistent() {}
-
   override async clearCache(): Promise<void> {
     // Clearing only the context cache does not work: https://bugzilla.mozilla.org/show_bug.cgi?id=1819147
     await this._browser.session.send('Browser.clearCache');

packages/playwright-core/src/server/firefox/ffBrowser.ts

@@ -409,7 +409,6 @@ export class WVBrowserContext extends BrowserContext {
       await (page.delegate as WVPage).exposePlaywrightBinding();
   }
 
-  override async onClosePersistent() {}
   override async doUpdateDefaultViewport() {}
   override async doUpdateDefaultEmulatedMedia() {}
   override async clearCache(): Promise<void> { throw new Error('Method not implemented.'); }

packages/playwright-core/src/server/webkit/webview/wvBrowser.ts

@@ -358,8 +358,6 @@ export class WKBrowserContext extends BrowserContext {
       await (page.delegate as WKPage).exposePlaywrightBinding();
   }
 
-  onClosePersistent() {}
-
   override async clearCache(): Promise<void> {
     // We use ephemeral contexts so there is no disk cache.
     await this._browser._browserSession.send('Playwright.clearMemoryCache', {

packages/playwright-core/src/server/webkit/wkBrowser.ts

@@ -192,7 +192,8 @@ async function runWatch() {
   for (const { files, from, to, ignored } of copyFiles) {
     const watcher = chokidar.watch([filePath(files)], { ignored });
     watcher.on('all', (event, file) => {
-      copyFile(file, from, to);
+      if (event === 'add' || event === 'change')
+        copyFile(file, from, to);
     });
   }