Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Fixed Python bug when enable_json_response=True #10376

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Feb 3, 2025

Description

Fixed Python bug when enable_json_response=True

Contribution Checklist

Fixes #10375

@shethaadit shethaadit requested a review from a team as a code owner February 3, 2025 18:18
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 3, 2025
@github-actions github-actions bot changed the title Fixed Python bug when enable_json_response=True Python: Fixed Python bug when enable_json_response=True Feb 3, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 3, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/open_ai
   open_ai_assistant_base.py5211398%188, 197–202, 282, 298–299, 767, 821, 1027, 1035, 1120, 1184
TOTAL17593235987% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3049 4 💤 0 ❌ 0 🔥 1m 10s ⏱️

@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

@shethaadit there are some unit tests that need to be updated (that were incorrectly looking at the enable_json_response config).

@shethaadit
Copy link
Contributor Author

Hi @moonbox3, I have fixed all Unit Tests and the run is 100% successful I believe. Could you please take a look at again and approve?

@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

Hi @moonbox3, I have fixed all Unit Tests and the run is 100% successful I believe. Could you please take a look at again and approve?

Definitely! Thank you for doing that.

@moonbox3 moonbox3 enabled auto-merge February 4, 2025 23:00
@shethaadit
Copy link
Contributor Author

Hi @moonbox3, somehow it shows all test case passed but merge-gatekeeper is failing. Can you please help?

@moonbox3 moonbox3 added this pull request to the merge queue Feb 4, 2025
@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

Hi @moonbox3, somehow it shows all test case passed but merge-gatekeeper is failing. Can you please help?

Yes, I'm on it, no worries.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

We've got a PR going in to unblock this -- our ollama integration tests are unstable, so we will be skipping them for now. I'll get this merged once that is in main.

@moonbox3 moonbox3 enabled auto-merge February 5, 2025 00:10
@moonbox3 moonbox3 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into microsoft:main with commit 7c10d5f Feb 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

Python: Bug: Assistant Agent enable json error
5 participants