Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Inconsistent API's in the Agent Framework #10390

Open
markwallace-microsoft opened this issue Feb 4, 2025 · 1 comment
Open

.Net: Inconsistent API's in the Agent Framework #10390

markwallace-microsoft opened this issue Feb 4, 2025 · 1 comment
Assignees
Labels
agents api_change PRs tagged with this label contain a change to the public API surface .NET Issue or Pull requests regarding .NET code question Further information is requested

Comments

@markwallace-microsoft
Copy link
Member

OpenAIAssistantAgent contains two factory methods CreateFromTemplateAsync and CreateAsync. AzureAIAgent doesn't have equivalent methods, should it?

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code agents api_change PRs tagged with this label contain a change to the public API surface labels Feb 4, 2025
@github-actions github-actions bot changed the title Inconsistent API's in the Agent Framework .Net: Inconsistent API's in the Agent Framework Feb 4, 2025
@sphenry sphenry removed the triage label Feb 4, 2025
@crickman
Copy link
Contributor

crickman commented Feb 4, 2025

The same functionality is present and demonstratd in sample, just in a more slim form. Ultimately, the direction here is to do less abstraction / wrapping and focus more on the orchestration/interaction patterns.

Specifically, for the assistant api we managed the creation and retrieval of the remote/api definition.

In the new direction, the developer is expected to do this with the native client and simply provide the definition/model to the agent class.

The new declarative model you've been working on can encapsulate api interations in the factory. I think this is a good separate and we discussed it as a team (Ben, Evan, and myself).

Note: Technically this isn't a change to public API surface (as labeled)...its more of an issue on how the two packages align.

#10397

@crickman crickman added the question Further information is requested label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents api_change PRs tagged with this label contain a change to the public API surface .NET Issue or Pull requests regarding .NET code question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

3 participants