Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Support BetweenFilterClause or RangeFilterClause for Redis #10391

Open
moonbox3 opened this issue Feb 4, 2025 · 1 comment
Open

Python: Support BetweenFilterClause or RangeFilterClause for Redis #10391

moonbox3 opened this issue Feb 4, 2025 · 1 comment
Assignees
Labels
memory connector .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel

Comments

@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

There's a request extend our current FilterClauseBase, which only has EqualTo and AnyTagsEqualTo. We can do this by creating a new filter clause, like BetweenFilterClause or RangeFilterClause.

This also means we should extend the VectorSearchFilter (or SearchFilter) to allow .between(...).

The original ask is for Redis, but we should support this for others, too, if possible. For Redis we need to update _filters_to_redis_filters.

Tagging @westey-m for visibility for comments related to if there is (planned) support in .Net.

@moonbox3 moonbox3 added memory connector python Pull requests for the Python Semantic Kernel labels Feb 4, 2025
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Feb 4, 2025
@github-actions github-actions bot changed the title Python: Support BetweenFilterClause or RangeFilterClause for Redis .Net: Python: Support BetweenFilterClause or RangeFilterClause for Redis Feb 4, 2025
@westey-m
Copy link
Contributor

westey-m commented Feb 4, 2025

@moonbox3, in .net we are looking into using linq for expressing filters, which removes the need for a custom expression tree using filter clauses. Linq is a .net concept though, so not applicable to python. See #10156

Certainly more filter clauses are required beyond what we support today though. They were only intended to be the bare minimum to ship our preview and adding support for not, nesting, or, range filters, etc. will be important.

@sphenry sphenry assigned sphenry and eavanvalkenburg and unassigned sphenry Feb 4, 2025
@sphenry sphenry removed the triage label Feb 4, 2025
@sphenry sphenry moved this to Backlog: Not Planned in Semantic Kernel Feb 4, 2025
@moonbox3 moonbox3 changed the title .Net: Python: Support BetweenFilterClause or RangeFilterClause for Redis Python: Support BetweenFilterClause or RangeFilterClause for Redis Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory connector .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
Status: Backlog: Not Planned
Development

No branches or pull requests

5 participants