Restart-connection on an active terminal does not terminate original process

[cronhan]

Windows Terminal version

1.19.11213.0

Windows build number

10.0.22631.3447

Other Software

No response

Steps to reproduce

• Open Windows terminal
• Open Process Explorer and find the WindowsTerminal.exe process in the tree
• Observe that there is one OpenConsole.exe and a shell process e.g. pwsh.exe
• Run the "Restart connection" command
• Observe that there are now two OpenConsole.exe and pwsh.exe (or whatever was running before), and there is no way to interact with the original processes (that I am aware of)

Expected Behavior

Running "Restart connection" terminates the shell in the current tab before launching a new one (or after, I don't care).

Actual Behavior

The original shell process remains and is not accessible any more.

[WhatsACloud]

Hey @zadjii-msft! I noticed this issue hasn't been worked on in a while. Would you like me to take this one for you? I'm new to open source, so I'm more than eager to help around!

[zadjii-msft]

Please go for it! I personally haven't had a chance to work on the Terminal for months, so please have at it. I can try and point you in the right direction if you need.

This is where the connection is actually restarted:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 3466 to 3479 in 25392ea

	void TerminalPage::_restartPaneConnection(
	const TerminalApp::TerminalPaneContent& paneContent,
	const winrt::Windows::Foundation::IInspectable&)
	{
	// Note: callers are likely passing in `nullptr` as the args here, as
	// the TermControl.RestartTerminalRequested event doesn't actually pass
	// any args upwards itself. If we ever change this, make sure you check
	// for nulls
	if (const auto& connection{ _duplicateConnectionForRestart(paneContent) })
	{
	paneContent.GetTermControl().Connection(connection);
	connection.Start();
	}
	}

My guess is that there's another reference to the connection somewhere that's preventing the original one from getting released. Or maybe we need to manually exit the original one.