Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybind to suppress all keybinds #18067

Open
ra-jain opened this issue Oct 16, 2024 · 6 comments
Open

Keybind to suppress all keybinds #18067

ra-jain opened this issue Oct 16, 2024 · 6 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@ra-jain
Copy link

ra-jain commented Oct 16, 2024

Description of the new feature/enhancement

We have a lot of programs like vim or others which could have keybinds that map to the same which is in terminal the keyboard is kind of limited for all the possible keybinds to not be used when running this command

Proposed technical implementation details (optional)

In general we could have a keybind that maps to one key combination when pressed would disable all keybinds and when task is done we can come back

@ra-jain ra-jain added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 16, 2024
@PriyanshSrivastava0305
Copy link

PriyanshSrivastava0305 commented Oct 17, 2024

I think i could take a look at it. Can I ?
@ra-jain

@ra-jain
Copy link
Author

ra-jain commented Oct 17, 2024

Please do

@PriyanshSrivastava0305
Copy link

Please do

on it.

@zadjii-msft
Copy link
Member

Hmm. I can't seem to find this on the backlog, so kudos. It's a little like #5790, but instead of just a different keymap, you want to just skip all keys.

It's pretty trivial to add an action, so that should be easy. And it should be easy enough to add a flag inside TermControl / ControlCore to have it skip keybindings.

The trick I'd have here is: does activating this action skip the next key, or all keybinds till this action is triggered again? And if it's the latter, then how would the Terminal ever know to re-activate keybindings, if you can't press a keybinding to reactivate it?

But the former (just skip keybindings for the next key), that seems trivial to implement.

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 21, 2024
@zadjii-msft zadjii-msft added this to the Backlog milestone Oct 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 21, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2024
@carlos-zamora
Copy link
Member

carlos-zamora commented Oct 23, 2024

Thanks for filing. Could you provide a little more information about your scenario? Which vim are you using (in WSL? VIM for windows?) Is it one particular keybinding? /?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Oct 23, 2024
@ra-jain
Copy link
Author

ra-jain commented Oct 28, 2024

I had some situations with neovim on windows and my cutom keybinds like ctrl + O. It is not any particular keybinding but this could be a general improvement against all programs. Please let me know if you have any thoughts.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Oct 28, 2024
@carlos-zamora carlos-zamora removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants