Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Tuples/ValueTuples that have size >= 8 #4624

Open
Youssef1313 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #4639
Open

Handle Tuples/ValueTuples that have size >= 8 #4624

Youssef1313 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #4639
Assignees
@Youssef1313
Labels
Area: Parameterized tests In-PR
Milestone
MSTest 3.8 / Plat...

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 13, 2025 •
edited
Loading

testfx/src/Adapter/MSTest.TestAdapter/DynamicDataOperations.cs

Line 245 in c749676

genericTypeDefinition == typeof(ValueTuple<,,,,,,,>))

The last generic parameter here is a TRest and is not handled correctly.

The same applies to Tuples as well.

AB#2342947
@Youssef1313 Youssef1313 changed the title Handle ValueTuples that have size >= 8 Handle Tuples/ValueTuples that have size >= 8 Jan 13, 2025
@Youssef1313 Youssef1313 added this to the MSTest 3.8 / Platform 1.6 milestone Jan 13, 2025
@Youssef1313 Youssef1313 self-assigned this Jan 13, 2025
@Youssef1313 Youssef1313 added sprint and removed sprint labels Jan 13, 2025
@Youssef1313 Youssef1313 linked a pull request Jan 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Parameterized tests In-PR
Projects
None yet
Milestone
MSTest 3.8 / Platform 1.6
Development

Successfully merging a pull request may close this issue.

Fix Tuple/ValueTuple handling of TRest Youssef1313/testfx
1 participant
@Youssef1313