-
Notifications
You must be signed in to change notification settings - Fork 290
Fix OSConditionAttribute to detect OS via reflection for .NET Framework on Mono #7001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+74
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .NET Framework Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Copilot
AI
changed the title
[WIP] Fix OSConditionAttribute to work for netfx on Linux
Fix OSConditionAttribute to detect OS via reflection for .NET Framework on Mono
Nov 27, 2025
Copilot finished work on behalf of
Evangelink
November 27, 2025 10:07
Evangelink
reviewed
Nov 28, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Nov 28, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 29, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 29, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 29, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 29, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Show resolved
Hide resolved
…ionAttribute.cs Co-authored-by: Youssef Victor <[email protected]>
…ionAttribute.cs Co-authored-by: Youssef Victor <[email protected]>
Youssef1313
reviewed
Dec 1, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
…ionAttribute.cs Co-authored-by: Youssef Victor <[email protected]>
Youssef1313
reviewed
Dec 1, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Dec 1, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
approved these changes
Dec 2, 2025
Evangelink
reviewed
Dec 2, 2025
src/TestFramework/TestFramework/Attributes/TestMethod/OSConditionAttribute.cs
Outdated
Show resolved
Hide resolved
Youssef1313
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSConditionAttributeassumed .NET Framework always means Windows, causing[OSCondition(OperatingSystems.Windows)]tests to run on Linux/Mac when using Mono.Changes
Use
RuntimeInformation.IsOSPlatformvia reflection for NETFRAMEWORK buildsRuntimeInformationfromSystem.Runtime.InteropServices.RuntimeInformationassembly ormscorlib(Mono)Cache detected OS at class load time to avoid repeated reflection overhead
Add exception handling for reflection invocations
Fixes #6615
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
8xbvsblobprodcus382.vsblob.vsassets.io/usr/bin/dotnet dotnet msbuild /home/REDACTED/work/testfx/testfx/src/TestFramework/TestFramework/TestFramework.csproj /t:PrintTargetFrameworks /p:TargetFramework=netstandard2.0 /nologo(dns block)/usr/bin/dotnet dotnet msbuild /home/REDACTED/work/testfx/testfx/src/TestFramework/TestFramework/TestFramework.csproj /pp(dns block)/home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.25575.1.txt t.IsInstanceOfType.cs(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.