Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned images and masks in SSL4EO-L benchmark dataset #2345

Open
7 tasks
adamjstewart opened this issue Oct 11, 2024 · 2 comments
Open
7 tasks

Misaligned images and masks in SSL4EO-L benchmark dataset #2345

adamjstewart opened this issue Oct 11, 2024 · 2 comments
Labels
datasets Geospatial or benchmark datasets scripts Training and evaluation scripts

Comments

@adamjstewart
Copy link
Collaborator

Description

There is a reprojection bug in the script we used to download SSL4EO-L. The result of this is that the bbox of each file is slightly off (up to 10 px). This doesn't really matter much for the SSL version of the dataset, but the benchmark version of the dataset (NLCD, CDL) has masks that are not properly aligned with the images.

TODO:

  • Fix the reprojection bug in download_ssl4eo.py
  • Re-download the images in our benchmark datasets
  • Re-chip the mask products in our benchmark datasets
  • Upload the fixed benchmark datasets to HF
  • Update downloads and checksums in our TorchGeo datasets
  • Re-download/upload/update the pure-SSL versions of the dataset?
  • Re-run benchmark experiments and update SSL4EO-L paper?

Thanks @Vikki23 for reporting this issue and @AABNassim @wangyi111 for investigating it!

Steps to reproduce

Look at any two pairs of images in GIS software to see the misalignment.

Version

0.6.1

@adamjstewart adamjstewart added datasets Geospatial or benchmark datasets scripts Training and evaluation scripts labels Oct 11, 2024
@adamjstewart adamjstewart added this to the 0.6.2 milestone Oct 11, 2024
@adamjstewart adamjstewart modified the milestones: 0.6.2, 0.6.3 Dec 5, 2024
@adamjstewart
Copy link
Collaborator Author

@AABNassim any updates on this?

@adamjstewart adamjstewart removed this from the 0.6.3 milestone Mar 13, 2025
@AABNassim
Copy link
Contributor

AABNassim commented Mar 21, 2025

Sorry, was very busy lately.

Conrad wrote the updated GEE downloading script which we used to download the new version of SSL4EO-S12, with the spatial alignment issue fixed, and everything in native UTM zones. Maybe he could push it? His GitHub ID: @cmalbrec

cmalbrec added a commit to cmalbrec/torchgeo that referenced this issue Mar 22, 2025
cmalbrec added a commit to cmalbrec/torchgeo that referenced this issue Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets scripts Training and evaluation scripts
Projects
None yet
Development

No branches or pull requests

2 participants