Clone watcher compiler configurations before comparison to prevent unintended recompilation (#1197)

ephemer · jakebailey · web-flow · commit 276ff5f3f706 · 2025-06-16T18:03:14.000Z
Co-authored-by: Jake Bailey &lt;5341706+jakebailey@users.noreply.github.com&gt;
diff --git a/internal/execute/watcher.go b/internal/execute/watcher.go
@@ -54,7 +54,8 @@ func (w *watcher) hasErrorsInTsConfig() bool {
 			}
 			return true
 		}
-		if !reflect.DeepEqual(w.options.CompilerOptions(), configParseResult.CompilerOptions()) {
+		// CompilerOptions contain fields which should not be compared; clone to get a copy without those set.
+		if !reflect.DeepEqual(w.options.CompilerOptions().Clone(), configParseResult.CompilerOptions().Clone()) {
 			// fmt.Fprint(w.sys.Writer(), "build triggered due to config change", w.sys.NewLine())
 			w.configModified = true
 		}

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,8 @@ func (w *watcher) hasErrorsInTsConfig() bool {`
`54`	`54`	`}`
`55`	`55`	`return true`
`56`	`56`	`}`
`57`		`- if !reflect.DeepEqual(w.options.CompilerOptions(), configParseResult.CompilerOptions()) {`
	`57`	`+ // CompilerOptions contain fields which should not be compared; clone to get a copy without those set.`
	`58`	`+ if !reflect.DeepEqual(w.options.CompilerOptions().Clone(), configParseResult.CompilerOptions().Clone()) {`
`58`	`59`	`// fmt.Fprint(w.sys.Writer(), "build triggered due to config change", w.sys.NewLine())`
`59`	`60`	`w.configModified = true`
`60`	`61`	`}`