Ensure pool mutex is locked in GetAllCheckers (#1169)

jakebailey · web-flow · commit 877603ea46d0 · 2025-06-12T00:16:29.000Z
diff --git a/internal/project/checkerpool.go b/internal/project/checkerpool.go
@@ -87,6 +87,9 @@ func (p *checkerPool) Files(checker *checker.Checker) iter.Seq[*ast.SourceFile]
 }
 
 func (p *checkerPool) GetAllCheckers(ctx context.Context) ([]*checker.Checker, func()) {
+	p.mu.Lock()
+	defer p.mu.Unlock()
+
 	requestID := core.GetRequestID(ctx)
 	if requestID == "" {
 		panic("cannot call GetAllCheckers on a project.checkerPool without a request ID")

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,9 @@ func (p checkerPool) Files(checker checker.Checker) iter.Seq[*ast.SourceFile]`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`func (p checkerPool) GetAllCheckers(ctx context.Context) ([]checker.Checker, func()) {`
	`90`	`+ p.mu.Lock()`
	`91`	`+ defer p.mu.Unlock()`
	`92`	`+`
`90`	`93`	`requestID := core.GetRequestID(ctx)`
`91`	`94`	`if requestID == "" {`
`92`	`95`	`panic("cannot call GetAllCheckers on a project.checkerPool without a request ID")`