fix(2157): jsdocfunction param is inferred as implicit any when directly assigned to module.exports (#2158)

Author: a-tarasyuk

internal/fourslash/_scripts/failingTests.txt

@@ -242,7 +242,6 @@ TestGetJavaScriptCompletions10
 TestGetJavaScriptCompletions12
 TestGetJavaScriptCompletions13
 TestGetJavaScriptCompletions15
-TestGetJavaScriptCompletions18
 TestGetJavaScriptCompletions20
 TestGetJavaScriptCompletions8
 TestGetJavaScriptCompletions9

internal/fourslash/tests/gen/getJavaScriptCompletions18_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestGetJavaScriptCompletions18(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @allowNonTsExtensions: true
 // @Filename: file.js

internal/parser/reparser.go

@@ -587,6 +587,10 @@ func getFunctionLikeHost(host *ast.Node) (*ast.Node, bool) {
 		fun = host.Expression()
 	} else if host.Kind == ast.KindReturnStatement {
 		fun = host.Expression()
+	} else if host.Kind == ast.KindExpressionStatement {
+		if ast.IsBinaryExpression(host.Expression()) {
+			fun = host.Expression().AsBinaryExpression().Right
+		}
 	}
 	if ast.IsFunctionLike(fun) {
 		return fun, true

testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.errors.txt

@@ -32,5 +32,26 @@ module.exports = function loader(options) { };
 export type Options = {
     opt: string;
 };
-declare const _default: (options: any) => void;
+declare const _default: (options: Options) => void;
 export = _default;
+
+
+//// [DtsFileErrors]
+
+
+out/index.d.ts(9,1): error TS2309: An export assignment cannot be used in a module with other exported elements.
+
+
+==== out/index.d.ts (1 errors) ====
+    /**
+     * @typedef Options
+     * @property {string} opt
+     */
+    export type Options = {
+        opt: string;
+    };
+    declare const _default: (options: Options) => void;
+    export = _default;
+    ~~~~~~~~~~~~~~~~~~
+!!! error TS2309: An export assignment cannot be used in a module with other exported elements.
+    

testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.errors.txt.diff

@@ -17,5 +17,26 @@
 +export type Options = {
      opt: string;
  };
-+declare const _default: (options: any) => void;
-+export = _default;
++declare const _default: (options: Options) => void;
++export = _default;
++
++
++//// [DtsFileErrors]
++
++
++out/index.d.ts(9,1): error TS2309: An export assignment cannot be used in a module with other exported elements.
++
++
++==== out/index.d.ts (1 errors) ====
++    /**
++     * @typedef Options
++     * @property {string} opt
++     */
++    export type Options = {
++        opt: string;
++    };
++    declare const _default: (options: Options) => void;
++    export = _default;
++    ~~~~~~~~~~~~~~~~~~
++!!! error TS2309: An export assignment cannot be used in a module with other exported elements.
++    

testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js

@@ -10,11 +10,11 @@
  * @param {Options} options
  */
 module.exports = function loader(options) {}
->module.exports = function loader(options) {} : (options: any) => void
->module.exports : (options: any) => void
->module : { "export=": (options: any) => void; }
->exports : (options: any) => void
->function loader(options) {} : (options: any) => void
->loader : (options: any) => void
->options : any
+>module.exports = function loader(options) {} : (options: Options) => void
+>module.exports : (options: Options) => void
+>module : { "export=": (options: Options) => void; }
+>exports : (options: Options) => void
+>function loader(options) {} : (options: Options) => void
+>loader : (options: Options) => void
+>options : Options
 

testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff

@@ -1,20 +1,11 @@
 --- old.jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.types
 +++ new.jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.types
-@@= skipped -9, +9 lines =@@
-  * @param {Options} options
-  */
+@@= skipped -11, +11 lines =@@
  module.exports = function loader(options) {}
-->module.exports = function loader(options) {} : (options: Options) => void
-->module.exports : (options: Options) => void
+ >module.exports = function loader(options) {} : (options: Options) => void
+ >module.exports : (options: Options) => void
 ->module : { exports: (options: Options) => void; }
-->exports : (options: Options) => void
-->function loader(options) {} : (options: Options) => void
-->loader : (options: Options) => void
-->options : Options
-+>module.exports = function loader(options) {} : (options: any) => void
-+>module.exports : (options: any) => void
-+>module : { "export=": (options: any) => void; }
-+>exports : (options: any) => void
-+>function loader(options) {} : (options: any) => void
-+>loader : (options: any) => void
-+>options : any
++>module : { "export=": (options: Options) => void; }
+ >exports : (options: Options) => void
+ >function loader(options) {} : (options: Options) => void
+ >loader : (options: Options) => void

testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.types

@@ -1,13 +1,13 @@
-jsElementAccessNoContextualTypeCrash.js(2,1): error TS2322: Type '{ localize: (string: any) => any; } | {}' is not assignable to type '{ localize: (string: any) => any; }'.
-  Property 'localize' is missing in type '{}' but required in type '{ localize: (string: any) => any; }'.
+jsElementAccessNoContextualTypeCrash.js(2,1): error TS2322: Type '{ localize: (string: string) => string; } | {}' is not assignable to type '{ localize: (string: string) => string; }'.
+  Property 'localize' is missing in type '{}' but required in type '{ localize: (string: string) => string; }'.
 
 
 ==== jsElementAccessNoContextualTypeCrash.js (1 errors) ====
     var Common = {};
     self['Common'] = self['Common'] || {};
     ~~~~~~~~~~~~~~
-!!! error TS2322: Type '{ localize: (string: any) => any; } | {}' is not assignable to type '{ localize: (string: any) => any; }'.
-!!! error TS2322:   Property 'localize' is missing in type '{}' but required in type '{ localize: (string: any) => any; }'.
+!!! error TS2322: Type '{ localize: (string: string) => string; } | {}' is not assignable to type '{ localize: (string: string) => string; }'.
+!!! error TS2322:   Property 'localize' is missing in type '{}' but required in type '{ localize: (string: string) => string; }'.
 !!! related TS2728 jsElementAccessNoContextualTypeCrash.js:7:1: 'localize' is declared here.
     /**
      * @param {string} string