Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model factory - new parameters should be added to end of list #5587

Closed
JoshLove-msft opened this issue Jan 13, 2025 · 1 comment
Closed

Model factory - new parameters should be added to end of list #5587

JoshLove-msft opened this issue Jan 13, 2025 · 1 comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

When a new model factory overload is added, the parameter order should match the existing overload (which must still be generated based on the last contract view). Any new parameters should be added to the end of the list.
@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 13, 2025
@JoshLove-msft
Copy link
Contributor Author

It is sort of Garbage In Garbage out if you are changing around the property ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshLove-msft