0.32.1: stop creating temp files in workspace (#687)

Eskibear · web-flow · commit 1c63ac27e4b3 · 2021-07-28T17:05:52.000+08:00
Signed-off-by: Yan Zhang &lt;yanzh@microsoft.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Change Log
 All notable changes to the "vscode-maven" extension will be documented in this file.
 
+## 0.32.1
+### Fixed
+- A text file was wrongly created in workspace when calculating depenencies.
+
 ## 0.32.0
 ### Added
 - [Preview] Improve dependency management experience. [#261](https://github.com/microsoft/vscode-maven/issues/261)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "vscode-maven",
   "displayName": "Maven for Java",
   "description": "%description%",
-  "version": "0.32.0",
+  "version": "0.32.1",
   "icon": "resources/logo.png",
   "publisher": "vscjava",
   "preview": true,
diff --git a/src/utils/mavenUtils.ts b/src/utils/mavenUtils.ts
@@ -40,8 +40,10 @@ export async function rawEffectivePom(pomPath: string, options?: {cacheOnly?: bo
 }
 
 export async function rawDependencyTree(pomPath: string): Promise<any> {
-    const outputDirectory: string = path.dirname(pomPath);
-    const outputFileName: string = "dependency-graph.txt";
+    const outputPath: string = getTempFolder(pomPath);
+    const dependencyGraphPath: string = `${outputPath}.deps.txt`;
+    const outputDirectory: string = path.dirname(dependencyGraphPath);
+    const outputFileName: string = path.basename(dependencyGraphPath);
     await executeInBackground(`com.github.ferstl:depgraph-maven-plugin:graph -DgraphFormat=text -DshowDuplicates -DshowConflicts -DshowVersions -DshowGroupIds -DoutputDirectory="${outputDirectory}" -DoutputFileName="${outputFileName}"`, pomPath);
     return await readFileIfExists(path.join(outputDirectory, outputFileName));
 }

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,10 @@ export async function rawEffectivePom(pomPath: string, options?: {cacheOnly?: bo`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`export async function rawDependencyTree(pomPath: string): Promise<any> {`
`43`		`- const outputDirectory: string = path.dirname(pomPath);`
`44`		`- const outputFileName: string = "dependency-graph.txt";`
	`43`	`+ const outputPath: string = getTempFolder(pomPath);`
	`44`	+ const dependencyGraphPath: string = `${outputPath}.deps.txt`;
	`45`	`+ const outputDirectory: string = path.dirname(dependencyGraphPath);`
	`46`	`+ const outputFileName: string = path.basename(dependencyGraphPath);`
`45`	`47`	await executeInBackground(`com.github.ferstl:depgraph-maven-plugin:graph -DgraphFormat=text -DshowDuplicates -DshowConflicts -DshowVersions -DshowGroupIds -DoutputDirectory="${outputDirectory}" -DoutputFileName="${outputFileName}"`, pomPath);
`46`	`48`	`return await readFileIfExists(path.join(outputDirectory, outputFileName));`
`47`	`49`	`}`