Skip to content

Debugging with integratedTerminal ignores defaultProfile #16363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozendelait opened this issue Jun 2, 2021 · 2 comments
Closed

Debugging with integratedTerminal ignores defaultProfile #16363

ozendelait opened this issue Jun 2, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@ozendelait
Copy link

Environment data

  • VS Code version: 1.56.2
  • Extension version (available under the Extensions sidebar): v2021.5.842923320
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Relevant/affected Python packages and their versions: all
  • Relevant/affected Python-related VS Code extensions and their versions: unknown
  • Value of the python.languageServer setting: 2021.5.4 (pyright fd334302)

Expected behaviour

debugging with "console": "integratedTerminal" should use the Terminal selected by "terminal.integrated.defaultProfile.windows"

Actual behaviour

PowerShell is used

Steps to reproduce:

1.) set "terminal.integrated.defaultProfile.windows" (to e.g. bash) in user settings
2.) File / Open Folder / 3.) Run and Debug (Ctrl + Shift +D) 4.) Click "Open a file" /
5.) Click "Run and Debug" Button (select "Python" from drop-down)

@ozendelait ozendelait added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Jun 2, 2021
@karthiknadig karthiknadig self-assigned this Jun 2, 2021
@karthiknadig
Copy link
Member

This is probably side effect of VS Code's change in the terminal settings (see #16175). From the debugger we send back runInTerminal request, and the request is entirely handled by VS Code editor and not the extension. This should be filed on VS Code. When you file on VS Code, please mention this issue so they know this was triaged by the python extension.

@ozendelait
Copy link
Author

Thanks; I added an issue at the vscode repo:
microsoft/vscode#125918

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants