Skip to content

Test: Use container features from OCI registry #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
chrmarti opened this issue Aug 22, 2022 · 2 comments
Closed
2 tasks done

Test: Use container features from OCI registry #7102

chrmarti opened this issue Aug 22, 2022 · 2 comments
Labels
containers Issue in vscode-remote containers testplan-item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Aug 22, 2022

Refs: devcontainers/cli#88

Complexity: 3

Create Issue


Use the latest Remote-Containers pre-release (currently 0.248.0) or Dev Containers CLI (currently 0.12.1) for testing.

Note that the new feature id syntax shows an error decoration in the editor because it is not yet officially supported.

{
	"image": "mcr.microsoft.com/vscode/devcontainers/base:0-bullseye",
	"features": {
		"ghcr.io/devcontainers/features/node": "latest"
	}
}
@chrmarti chrmarti added this to the August 2022 milestone Aug 22, 2022
@chrmarti chrmarti added the containers Issue in vscode-remote containers label Aug 22, 2022
@ghost ghost assigned paulacamargo25 and dbaeumer Aug 23, 2022
@dbaeumer dbaeumer removed their assignment Aug 24, 2022
@lszomoru lszomoru assigned alexr00 and unassigned paulacamargo25 Aug 25, 2022
@alexdima
Copy link
Member

alexdima commented Aug 25, 2022

Notes from the standup discussion:

  1. "ghcr.io/devcontainers/features/go:1": "latest" is very confusing
  2. version might be better called goVersion, nodeVersion, etc:
"ghcr.io/devcontainers/features/go:1": {
    "version": "latest" // maybe better called "goVersion"?
}

compare with actions:

- uses: actions/setup-node@v3
  with:
    node-version: 16
  1. Consider using @ for feature version instead of :

@alexr00
Copy link
Member

alexr00 commented Aug 25, 2022

I tried adding

    "features": {
        "go": "latest"
    }

to my devcontainer.json, but when I rebuilt I got this error:

[2022-08-25T14:30:50.275Z] * Fetching feature: go_1_local-cache
[2022-08-25T14:30:50.309Z] Feature go is not a 'v2' feature. Attempting fallback to 'v1' implementation.
[2022-08-25T14:30:50.315Z] Failed to find feature 'go' in provided v1 metadata file
[2022-08-25T14:30:50.315Z] (!) ERR: Failed to fetch feature: Failed to parse feature 'go_1_local-cache'. Please check your devcontainer.json 'features' attribute.
[2022-08-25T14:30:50.316Z] Error: Failed to parse feature 'go_1_local-cache'. Please check your devcontainer.json 'features' attribute.
[2022-08-25T14:30:50.317Z]

@alexr00 alexr00 removed their assignment Aug 26, 2022
@alexr00 alexr00 closed this as completed Aug 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants