Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal ligatures (stable) #238882

Closed
2 tasks done
Tyriar opened this issue Jan 27, 2025 · 1 comment
Closed
2 tasks done

Test: Terminal ligatures (stable) #238882

Tyriar opened this issue Jan 27, 2025 · 1 comment

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 27, 2025

Refs: #233006, #237492

Complexity: 3

Create Issue


Terminal ligatures were tested last month but several important issues have been fixed and the feature declared stable. Here are the main changes, please test and verify them:

  • terminal.integrated.fontLigatures changed to terminal.integrated.fontLigatures.enabled
  • Ligatures should work mostly the same whether terminal.integrated.gpuAcceleration or "on" or "off"
  • There's a new terminal.integrated.fontLigatures.featureSettings setting that allows configuring a font to use different ligature sets or character variants. I was testing this during development using Fira Code's stylistic sets
  • There's a new terminal.integrated.fontLigatures.fallbackLigatures setting for fonts that aren't supported (no need to verify this)
  • Ligatures should be temporarily disabled when either the selection or cursor is inside the ligature, this fixed the main 2 problems from last month.
@luabud
Copy link
Member

luabud commented Jan 28, 2025

LGTM. I wasn't able to get featureSettings to work but I also was not able to get editor.fontLigatures to work with the same value I was trying, so I think it may have been an issue with the font I am testing with.
The value I tried to configure was this:
"terminal.integrated.fontLigatures.featureSettings": "'ss19'",, based on microsoft/cascadia-code#407 (comment), as I wanted to swap the dotted zero with slash zero. But then "editor.fontLigatures": "'ssq19'", didn't do the trick for me on the editor either.
For that reason I didn't try filing an issue, but @Tyriar lmk if it's worth doing so.

@luabud luabud closed this as completed Jan 28, 2025
@luabud luabud removed their assignment Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants