Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test) Terminal Shell Type proposed API #238888

Closed
3 tasks done
anthonykim1 opened this issue Jan 27, 2025 · 2 comments
Closed
3 tasks done

Test) Terminal Shell Type proposed API #238888

anthonykim1 opened this issue Jan 27, 2025 · 2 comments

Comments

@anthonykim1
Copy link
Contributor

anthonykim1 commented Jan 27, 2025

Refs: #230165

Complexity: 3

Create Issue


Thank you in advance for testing.

Background Information

There are many times extensions try to predict the type of shell user is using for their Terminal.

This iteration, I added an proposed API https://github.com/microsoft/vscode/blob/e8346324cfb8b5d680ad657bb67153eb838aebc5/src/vscode-dts/vscode.proposed.terminalShellType.d.ts where shell type information is exposed from core to extensions.
Each of the enums provided meant to specify the type of the specific shell.


Setup

  • Please test this with wide variety of enum shells listed in the proposed API doc.
  • Make sure to enable proposed api name: terminalShellType

Testing

  1. Feel free to test on extension on your own.
  2. Subscribing to window.onDidChangeTerminalState and watch the shellType field.
  3. Make sure you get the "correct" shell enum depending on which shell you open inside VS Code
@sandy081
Copy link
Member

Tested for Zsh, Fish, Bash & PowerShell.

@sandy081 sandy081 removed their assignment Jan 28, 2025
@cwebster-99
Copy link
Member

Tested for git bash, pwsh, and cmd

@cwebster-99 cwebster-99 removed their assignment Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants