Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal copilot pushes prompt #238925

Closed
bpasero opened this issue Jan 28, 2025 · 8 comments
Closed

Terminal copilot pushes prompt #238925

bpasero opened this issue Jan 28, 2025 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 28, 2025

Image

In zoom 1, the cursor pushes up out of view.

Also the inline chat seems badly centered.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget labels Jan 28, 2025
@Tyriar Tyriar added this to the January 2025 milestone Jan 28, 2025
@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2025

Caused by faad121

I confirmed changing that back to .monaco-workbench .inline-chat .chat-widget .interactive-session .interactive-input-part fixes the problem.

@jrieken any recommendations here? We could just duplicate the rule in terminal land but you might have a better idea for how to do it in inline chat?

@jrieken
Copy link
Member

jrieken commented Jan 28, 2025

Caused by faad121

That's very surprising because the rule change should be a no-op unless you set the .inline-chat-2 class - which only the new inline chat controller (which is only used for inline chat) does

@jrieken
Copy link
Member

jrieken commented Jan 28, 2025

Now I get it, terminal isn't a zone widget

@jrieken
Copy link
Member

jrieken commented Jan 28, 2025

Also the inline chat seems badly centered.

I can reproduce that but the pushing of the terminal prompt not

@bpasero
Copy link
Member Author

bpasero commented Jan 28, 2025

Even without zooming I see it not being perfectly in the center (macOS). That is, the input field within the zone:

Image

@jrieken
Copy link
Member

jrieken commented Jan 28, 2025

That is, the input field within the zone:

Yeah, that I reproduce but your initial screen capture also shows a 1px clipping at the top of the terminal, e.g the terminal cursor isn't fully visible

@bpasero
Copy link
Member Author

bpasero commented Jan 28, 2025

Right, somehow I do not see this anymore now either 🤷

@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2025

The cursor thing is likely an unrelated issue which may only repro based on the exact pixel height of the panel. For a new terminal like this, chat is simply an overlay. I think @bpasero is just noticing it because the cursor switches from a filled block to a hollow block when chat grabs focus. You'd only notice a pixel missing if it was hollow.

@jrieken jrieken changed the title Terminal copilot pushes prompt (zoom 1) Terminal copilot pushes prompt Jan 28, 2025
jrieken added a commit that referenced this issue Jan 29, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 29, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget
Projects
None yet
Development

No branches or pull requests

4 participants