-
Notifications
You must be signed in to change notification settings - Fork 48
Description
Describe the bug
'make test' command is throwing errors. CNI tests shouldn't be skipped in the CI pipeline.
To Reproduce
Steps to reproduce the behavior:
- Comment out t.Skip statements in *_test.go files under the plugins directory.
- Run 'make test', and observe the below errors:
? github.com/Microsoft/windows-container-networking/cni [no test files]
? github.com/Microsoft/windows-container-networking/common [no test files]
? github.com/Microsoft/windows-container-networking/common/core [no test files]
? github.com/Microsoft/windows-container-networking/network [no test files]
=== RUN TestNatCmdAdd
connectivity_testing.go:320: Interface Found: [&{0 0 0}] with ip []
plugin_testing.go:49: Setup for Network Plugin of type: Nat ...
plugin_testing.go:50: [DEBUG] Using Host IP: []
plugin_testing.go:54: Error while creating supplied network: hcnCreateNetwork failed in Win32: Access is denied. (0x5)
plugin_testing.go:227: Running Unit Test
--- FAIL: TestNatCmdAdd (0.10s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0xc04557]
goroutine 18 [running]:
testing.tRunner.func1.2({0xc67f40, 0x10b4960})
C:/Program Files/Go/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
C:/Program Files/Go/src/testing/testing.go:1392 +0x39f
panic({0xc67f40, 0x10b4960})
C:/Program Files/Go/src/runtime/panic.go:838 +0x207
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunUnitTest(0xc000318780, 0xc000324820)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:228 +0x57
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunAll(0x0?, 0x0?)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:311 +0x34
github.com/Microsoft/windows-container-networking/plugins/nat_test.TestNatCmdAdd(0x7a5d3d?)
C:/github/windows-container-networking/plugins/nat/nat_windows_test.go:25 +0xcf
testing.tRunner(0xc000324820, 0xd1ffa0)
C:/Program Files/Go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
C:/Program Files/Go/src/testing/testing.go:1486 +0x35f
FAIL github.com/Microsoft/windows-container-networking/plugins/nat 0.692s
=== RUN TestBridgeCmdAdd
connectivity_testing.go:320: Interface Found: [&{0 0 0}] with ip []
plugin_testing.go:49: Setup for Network Plugin of type: L2Bridge ...
plugin_testing.go:50: [DEBUG] Using Host IP: []
plugin_testing.go:54: Error while creating supplied network: hcnCreateNetwork failed in Win32: Access is denied. (0x5)
plugin_testing.go:227: Running Unit Test
--- FAIL: TestBridgeCmdAdd (0.06s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0x884557]
goroutine 18 [running]:
testing.tRunner.func1.2({0x8e8f40, 0xd36960})
C:/Program Files/Go/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
C:/Program Files/Go/src/testing/testing.go:1392 +0x39f
panic({0x8e8f40, 0xd36960})
C:/Program Files/Go/src/runtime/panic.go:838 +0x207
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunUnitTest(0xc0000a6780, 0xc0000849c0)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:228 +0x57
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunAll(0x9770c7?, 0xc?)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:311 +0x34
github.com/Microsoft/windows-container-networking/plugins/sdnbridge_test.TestBridgeCmdAdd(0x425d3d?)
C:/github/windows-container-networking/plugins/sdnbridge/sdnbridge_windows_test.go:30 +0x112
testing.tRunner(0xc0000849c0, 0x9a0fc8)
C:/Program Files/Go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
C:/Program Files/Go/src/testing/testing.go:1486 +0x35f
FAIL github.com/Microsoft/windows-container-networking/plugins/sdnbridge 8.458s
=== RUN TestOverlayCmdAdd
connectivity_testing.go:320: Interface Found: [&{0 0 0}] with ip []
plugin_testing.go:49: Setup for Network Plugin of type: Overlay ...
plugin_testing.go:50: [DEBUG] Using Host IP: []
plugin_testing.go:54: Error while creating supplied network: hcnCreateNetwork failed in Win32: Access is denied. (0x5)
plugin_testing.go:227: Running Unit Test
--- FAIL: TestOverlayCmdAdd (0.09s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0x1074557]
goroutine 18 [running]:
testing.tRunner.func1.2({0x10d9120, 0x1526960})
C:/Program Files/Go/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
C:/Program Files/Go/src/testing/testing.go:1392 +0x39f
panic({0x10d9120, 0x1526960})
C:/Program Files/Go/src/runtime/panic.go:838 +0x207
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunUnitTest(0xc00031e780, 0xc00032a820)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:228 +0x57
github.com/Microsoft/windows-container-networking/test/utilities.(*PluginUnitTest).RunAll(0x0?, 0x0?)
C:/github/windows-container-networking/test/utilities/plugin_testing.go:311 +0x34
github.com/Microsoft/windows-container-networking/plugins/sdnoverlay_test.TestOverlayCmdAdd(0x0?)
C:/github/windows-container-networking/plugins/sdnoverlay/sdnoverlay_windows_test.go:43 +0xcf
testing.tRunner(0xc00032a820, 0x11912c0)
C:/Program Files/Go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
C:/Program Files/Go/src/testing/testing.go:1486 +0x35f
FAIL github.com/Microsoft/windows-container-networking/plugins/sdnoverlay 8.716s
=== RUN TestAutogenCniConf
Running Suite: autogencniconf - C:\github\windows-container-networking\scripts\autogencniconf\test
Random Seed: 1693719592
Will run 15 of 15 specs
+++++++++++++++
Ran 15 of 15 Specs in 19.675 seconds
SUCCESS! -- 15 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAutogenCniConf (19.68s)
PASS
ok github.com/Microsoft/windows-container-networking/scripts/autogencniconf/test (cached)
? github.com/Microsoft/windows-container-networking/test/container [no test files]
? github.com/Microsoft/windows-container-networking/test/utilities [no test files]
FAIL
Expected behavior
'make test' command should pass.
CNI Version
v0.3.0
Additional context
NA