Looking to update Malwarebytes.Malwarebytes

[scardenas-mb]

Hello, Im a MB employee looking to update the existing Malwarebytes.Malwarebytes package. Im running the wingetcreate tool locally but Im getting an error about a mismatch of installers. The existing manifest has a couple different links but the main download link points to an old offline installer. I would like to point it to the correct one which contains a bundled install package for all architectures.

Once I get pas the error I would like to add this step to our CICD pipeline to get it updated every release.

[scardenas-mb]

Command:
wingetcreate.exe update Malwarebytes.Malwarebytes -u "https://downloads.malwarebytes.com/file/mb5_offline" -v "5.5.1.240-151.0.5515" -t $env:GIT_PAT -s

Error:
The number of new installer packages must match the number of existing installer packages.

[mdanish-kh]

@scardenas-mb It looks like the current base manifest supports both x64 & x86, so to get the command to work you can use

wingetcreate.exe update Malwarebytes.Malwarebytes -u "https://downloads.malwarebytes.com/file/mb5_offline|x64" "https://downloads.malwarebytes.com/file/mb5_offline|x86" -v "5.5.1.240-151.0.5515"

[scardenas-mb]

will try this out and get back to you

[scardenas-mb]

If the error is due to the 4.x version, we should remove that from the manifest as we dont want to server anything but the latest which is 5.x currently.

[mdanish-kh]

wingetcreate uses the latest manifest at winget-pkgs as the base for an upgrade. It requires that the existing number of installers in the base manifest to match what's specified in the update command. For now, you will have to update the existing package manually at winget-pkgs if you want a single installer node and then you'll be able to automate the release once the base manifest is in the correct shape

[scardenas-mb]

Where can I go to get access to create a branch and submit prs to winget-pkgs

[mdanish-kh]

1. You can fork winget-pkgs under your account
2. Make changes in a branch in your fork
3. Open up a PR against microsoft/winget-pkgs

You can watch this episode of Open at Microsoft as well and follow from here as well:
https://github.com/microsoft/winget-pkgs#documentation

[scardenas-mb]

Yup I found that as I commented, thanks for the reply!

[scardenas-mb]

Since I forked and submitted a request to update the manifest to only serve 5.x, when will wininstall site get updated with that to no longer have 4.x as one other version to grab?

[mdanish-kh]

@scardenas-mb winnstall is not an official MSFT website. I'm not aware how long it takes for their website to update after the latest updates are reflected in the WinGet index.

For the WinGet CLI, after your PR gets merged (which is in this case is microsoft/winget-pkgs#346848), the publish pipeline kicks off to update the WinGet index. Once your changes are published, you will see a label Publish-Pipeline-Succeeded added to your PR. After that, you can use the command winget show Malwarebytes.Malwarebytes --versions and see that WinGet is no longer offering the 4.x version

For more details, you can check out the WinGet FAQ: How long do packages take to be published?