Back out explicit requeue

Author: djwhatle

pkg/controller/directimagemigration/directimagemigration_controller.go

@@ -118,15 +118,15 @@ func (r *ReconcileDirectImageMigration) Reconcile(request reconcile.Request) (re
 		if errors.IsNotFound(err) {
 			// Object not found, return.  Created objects are automatically garbage collected.
 			// For additional cleanup logic use finalizers.
-			return reconcile.Result{Requeue: false}, nil
+			return reconcile.Result{}, nil
 		}
 		// Error reading the object - requeue the request.
 		return reconcile.Result{Requeue: true}, err
 	}
 
 	// Completed.
 	if imageMigration.Status.Phase == Completed {
-		return reconcile.Result{Requeue: false}, nil
+		return reconcile.Result{}, nil
 	}
 
 	// Begin staging conditions

pkg/controller/directimagestreammigration/directimagestreammigration_controller.go

@@ -109,15 +109,15 @@ func (r *ReconcileDirectImageStreamMigration) Reconcile(request reconcile.Reques
 		if errors.IsNotFound(err) {
 			// Object not found, return.  Created objects are automatically garbage collected.
 			// For additional cleanup logic use finalizers.
-			return reconcile.Result{Requeue: false}, nil
+			return reconcile.Result{}, nil
 		}
 		// Error reading the object - requeue the request.
 		return reconcile.Result{Requeue: true}, err
 	}
 
 	// Completed.
 	if imageStreamMigration.Status.Phase == Completed {
-		return reconcile.Result{Requeue: false}, nil
+		return reconcile.Result{}, nil
 	}
 
 	// Begin staging conditions
@@ -163,5 +163,5 @@ func (r *ReconcileDirectImageStreamMigration) Reconcile(request reconcile.Reques
 		return reconcile.Result{RequeueAfter: requeueAfter}, nil
 	}
 
-	return reconcile.Result{Requeue: false}, nil
+	return reconcile.Result{}, nil
 }

pkg/controller/directvolumemigration/directvolumemigration_controller.go

@@ -99,7 +99,7 @@ func (r *ReconcileDirectVolumeMigration) Reconcile(request reconcile.Request) (r
 		if errors.IsNotFound(err) {
 			// Object not found, return.  Created objects are automatically garbage collected.
 			// For additional cleanup logic use finalizers.
-			return reconcile.Result{Requeue: false}, nil
+			return reconcile.Result{}, nil
 		}
 		// Error reading the object - requeue the request.
 		return reconcile.Result{Requeue: true}, err
@@ -110,7 +110,7 @@ func (r *ReconcileDirectVolumeMigration) Reconcile(request reconcile.Request) (r
 
 	// Check if completed
 	if direct.Status.Phase == Completed {
-		return reconcile.Result{Requeue: false}, nil
+		return reconcile.Result{}, nil
 	}
 
 	// Begin staging conditions

pkg/controller/migmigration/migmigration_controller.go

@@ -155,7 +155,7 @@ func (r *ReconcileMigMigration) Reconcile(request reconcile.Request) (reconcile.
 	if err != nil {
 		if errors.IsNotFound(err) {
 			err = r.deleted()
-			return reconcile.Result{Requeue: false}, nil
+			return reconcile.Result{}, nil
 		}
 		log.Info("Error getting migmigration for reconcile, requeueing.")
 		log.Trace(err)