Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Whois : information is on multiple lines #25

Open
sachinraste opened this issue Jan 22, 2020 · 1 comment
Open

Domain Whois : information is on multiple lines #25

sachinraste opened this issue Jan 22, 2020 · 1 comment

Comments

@sachinraste
Copy link
Contributor

Issue 1 :
Test Case : aud.edu
Explanation : While parsing the data , the parser encounters "registrant:", since the data is residing on multiple lines and since ":" is the last character, "registrant" key is not added to the result object.

Issue 2 :
Test Case : walmart.com
Explanation : Test is available in tests.js. However parse-raw-data.js hasnt yet been adapted to handle this data.

modifications : parse-raw-data.js
Added BLOCKSTART and BLOCKEND to handle multiple records while doing IP Whois
Added REGEX to find ": "
Added results.record Array, to hold multiple results served by IP Whois

modification : tests.js
Added the test for aud.edu

Repository : sachinraste/whois-json

Kindly review the code and if acceptable , PR would be sent.

@mikemaccana
Copy link
Owner

Heya - good spots! Just send the PR, that's where you do code reviews on GitHub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants