-
Notifications
You must be signed in to change notification settings - Fork 4
Added support for oEmbed. Needs testing. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
throoze
wants to merge
1
commit into
mileszim:master
Choose a base branch
from
throoze:feature/oembed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| require 'cgi' | ||
|
|
||
| module DocumentCloud | ||
| module API | ||
| module OEmbed | ||
| include DocumentCloud::API::Utils | ||
| OEMBED_PATH = '/api/oembed.json' | ||
|
|
||
| # Get oEmbed json object for a given document | ||
| # | ||
| # @see https://www.documentcloud.org/help/api#oembed | ||
| # @param url [String] The url of the document to be shown in the embeded visor | ||
| # @param options [Hash] Customizable set of options | ||
| # @param options [Integer] :maxheight The viewer's height (pixels) | ||
| # @param options [Integer] :maxwidth The viewer's width (pixels) | ||
| # @param options [String] :container Specify the DOM container in which to embed the viewer, example: '#my-document-div' | ||
| # @param options [Boolean] :notes Enable the notes tab. default: true | ||
| # @param options [Boolean] :text Enable the text tab. default: true | ||
| # @param options [Boolean] :zoom Show the zoom slider. default: true | ||
| # @param options [Boolean] :search Show the search box. default: true | ||
| # @param options [Boolean] :sidebar Show the sidebar. default: true | ||
| # @param options [Boolean] :pdf Include a link to the original PDF. default: true | ||
| # @param options [Boolean] :responsive Make the viewer responsive. default: false | ||
| # @param options [Integer] :responsive_offset Specify header height (pixels) | ||
| # @param options [Integer] :default_note Open the document to a specific note. An integer representing the note ID | ||
| # @param options [Integer] :default_page Open the document to a specific page | ||
| # @returns [DocumentCloud::OEmbed] object wrapper to oEmbed's json response | ||
| def oembed(url, options={}) | ||
| escaped_url = CGI.escape url | ||
| build_object DocumentCloud::oEmbed, get(OEMBED_PATH, options.merge(:url => escaped_url)) | ||
| end | ||
|
|
||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| module DocumentCloud | ||
| class OEmbed | ||
| attr_reader :type, :version, :provider_name, :provider_url, | ||
| :cache_age, :height, :width, :html | ||
|
|
||
| def initialize(attrs={}) | ||
| @type = attrs[:type] | ||
| @version = attrs[:version] | ||
| @provider_name = attrs[:provider_name] | ||
| @provider_url = attrs[:provider_url] | ||
| @cache_age = attrs[:cache_age] | ||
| @height = attrs[:height] | ||
| @width = attrs[:width] | ||
| @html = attrs[:html] | ||
| end | ||
|
|
||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the empty spaces before the "end" statements and I'm good with merging this :)