Skip to content

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Nov 25, 2025

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 7.54864% with 2376 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.18%. Comparing base (a0592aa) to head (4b13cc5).
⚠️ Report is 53 commits behind head on master.

⚠️ Current head 4b13cc5 differs from pull request most recent head 423ea17

Please upload reports for the commit 423ea17 to get more accurate results.

Files with missing lines Patch % Lines
src/impl/MilvusClientV2Impl.cpp 0.00% 897 Missing ⚠️
src/impl/request/dql/SearchRequest.cpp 0.00% 72 Missing ⚠️
...c/impl/request/partition/LoadPartitionsRequest.cpp 0.00% 70 Missing ⚠️
src/impl/request/dql/HybridSearchRequest.cpp 0.00% 69 Missing ⚠️
.../impl/request/collection/LoadCollectionRequest.cpp 0.00% 63 Missing ⚠️
src/impl/request/dql/QueryRequest.cpp 0.00% 58 Missing ⚠️
src/impl/request/dml/DeleteRequest.cpp 0.00% 50 Missing ⚠️
src/impl/utils/DqlUtils.cpp 10.00% 45 Missing ⚠️
...mpl/request/collection/CreateCollectionRequest.cpp 0.00% 35 Missing ⚠️
src/impl/request/dml/InsertRequest.cpp 0.00% 35 Missing ⚠️
... and 98 more

❌ Your patch check has failed because the patch coverage (7.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (51.18%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   53.47%   51.18%   -2.30%     
==========================================
  Files          52      171     +119     
  Lines        4432    10762    +6330     
  Branches        0     1062    +1062     
==========================================
+ Hits         2370     5508    +3138     
- Misses       2062     5161    +3099     
- Partials        0       93      +93     
Files with missing lines Coverage Δ
src/impl/MilvusClientImpl.h 100.00% <ø> (ø)
src/impl/types/AnalyzerResults.cpp 50.00% <ø> (ø)
src/impl/types/QueryIteratorImpl.cpp 77.55% <100.00%> (ø)
src/impl/types/SearchIteratorImpl.cpp 72.26% <100.00%> (ø)
src/impl/types/SearchIteratorV2Impl.cpp 89.00% <100.00%> (ø)
src/impl/types/SearchResults.cpp 84.21% <ø> (-15.79%) ⬇️
src/impl/utils/DqlUtils.h 44.44% <ø> (ø)
src/include/milvus/types/SearchResults.h 100.00% <ø> (ø)
src/include/milvus/types/SubSearchRequest.h 100.00% <ø> (ø)
src/impl/MilvusClientV2Impl.h 0.00% <0.00%> (ø)
... and 107 more

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants