Skip to content

Conversation

@nonfreegithub
Copy link
Contributor

No description provided.

init.lua Outdated
Comment on lines 38 to 39
-- Serializa y guarda en modstorage
local bytes = as:to_string() -- :contentReference[oaicite:3]{index=3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the comments in Spanish?
What does that contentReference mean?
Might an LLM be involved during this process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, comments removed

@SmallJoker
Copy link
Member

SmallJoker commented Nov 21, 2025

I pushed the first three commits to master as they were important bugfixes. As for the mod storage part - it honestly looks .. strange.

  1. The data save code and the new part of the migration are currently duplicates.
  2. The mod would need a proper check against Minetest >= 5.7 upon startup to show a helpful error to the user.
  3. mod.conf needs a version entry for >= 5.7.
  4. Some of the new comments describe what the line below does. That's not helpful. They should describe WHY it's being done like that (if necessary at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants