Fix non-recursive compares against alias+key on Windows (#4983)

Many listings would stop after the first version had been processed on Windows, since

For example, `mytls/testbucket/trace.json` != `mytls\testbucket\trace.json` would cause `mc undo` to only see one version since this would fail.

Use `getStandardizedURL` for both sides of these compares.

Author: klauspost

cmd/legalhold-info.go

@@ -177,7 +177,7 @@ func showLegalHoldInfo(ctx context.Context, urlStr, versionID string, timeRef ti
 			continue
 		}
 
-		if !recursive && alias+getKey(content) != getStandardizedURL(urlStr) {
+		if !recursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(urlStr) {
 			break
 		}
 

cmd/legalhold-set.go

@@ -129,7 +129,7 @@ func setLegalHold(ctx context.Context, urlStr, versionID string, timeRef time.Ti
 			continue
 		}
 
-		if !recursive && alias+getKey(content) != getStandardizedURL(urlStr) {
+		if !recursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(urlStr) {
 			break
 		}
 

cmd/retention-common.go

@@ -235,7 +235,7 @@ func applyRetention(ctx context.Context, op lockOpType, target, versionID string
 			continue
 		}
 
-		if !isRecursive && alias+getKey(content) != getStandardizedURL(target) {
+		if !isRecursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(target) {
 			break
 		}
 

cmd/retention-info.go

@@ -346,7 +346,7 @@ func getRetention(ctx context.Context, target, versionID string, timeRef time.Ti
 			continue
 		}
 
-		if !isRecursive && alias+getKey(content) != getStandardizedURL(target) {
+		if !isRecursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(target) {
 			break
 		}
 

cmd/rm-main.go

@@ -469,7 +469,7 @@ func listAndRemove(url string, opts removeOpts) error {
 		}
 
 		if !opts.isRecursive {
-			currentObjectURL := targetAlias + getKey(content)
+			currentObjectURL := getStandardizedURL(targetAlias + getKey(content))
 			standardizedURL := getStandardizedURL(currentObjectURL)
 			if !strings.HasPrefix(url, standardizedURL) {
 				break

cmd/stat.go

@@ -295,7 +295,7 @@ func statURL(ctx context.Context, targetURL, versionID string, timeRef time.Time
 			continue
 		}
 
-		url := targetAlias + getKey(content)
+		url := getStandardizedURL(targetAlias + getKey(content))
 		standardizedURL := getStandardizedURL(targetURL)
 
 		if !isRecursive && !strings.HasPrefix(filepath.FromSlash(url), standardizedURL) && !filepath.IsAbs(url) {

cmd/tag-list.go

@@ -235,7 +235,7 @@ func mainListTag(cliCtx *cli.Context) error {
 			continue
 		}
 
-		if !recursive && alias+getKey(content) != getStandardizedURL(targetURL) {
+		if !recursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(targetURL) {
 			break
 		}
 

cmd/tag-remove.go

@@ -192,7 +192,7 @@ func mainRemoveTag(cliCtx *cli.Context) error {
 			continue
 		}
 
-		if !recursive && alias+getKey(content) != getStandardizedURL(targetURL) {
+		if !recursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(targetURL) {
 			break
 		}
 

cmd/tag-set.go

@@ -210,7 +210,7 @@ func mainSetTag(cliCtx *cli.Context) error {
 			continue
 		}
 
-		if !recursive && alias+getKey(content) != getStandardizedURL(targetURL) {
+		if !recursive && getStandardizedURL(alias+getKey(content)) != getStandardizedURL(targetURL) {
 			break
 		}
 

cmd/undo-main.go

@@ -227,7 +227,7 @@ func undoURL(ctx context.Context, aliasedURL string, last int, recursive, dryRun
 		}
 
 		if !recursive {
-			if alias+getKey(content) != getStandardizedURL(aliasedURL) {
+			if getStandardizedURL(alias+getKey(content)) != getStandardizedURL(aliasedURL) {
 				break
 			}
 		}