Patch for Content description being announced twice for clickable icons (microsoft#594)

* Icon announcing it's content description twice for clickable icons

* Do not apply clickable for App Icon if onCLick = null

* header semantics for app bar basic text

---------

Co-authored-by: Anubhav Agrawal <[email protected]>

Author: Anubhvv

fluentui_core/src/main/java/com/microsoft/fluentui/theme/token/FluentIcon.kt

@@ -156,7 +156,6 @@ fun Icon(
             interactionSource = remember { MutableInteractionSource() },
             indication = LocalIndication.current,
             enabled = enabled,
-            onClickLabel = contentDescription,
             onClick = onClick
         ) else Modifier
     )

fluentui_topappbars/src/main/java/com/microsoft/fluentui/tokenized/AppBar.kt

@@ -18,6 +18,8 @@ import androidx.compose.ui.geometry.Offset
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.platform.testTag
+import androidx.compose.ui.semantics.heading
+import androidx.compose.ui.semantics.semantics
 import androidx.compose.ui.text.ExperimentalTextApi
 import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.text.style.TextOverflow
@@ -145,13 +147,16 @@ fun AppBar(
                     Icon(
                         navigationIcon,
                         modifier =
-                        Modifier
-                            .clickable(
+                        Modifier.then(
+                            if(navigationIcon.onClick != null)
+                                Modifier.clickable(
                                 interactionSource = remember { MutableInteractionSource() },
                                 indication = rememberRipple(color = token.navigationIconRippleColor()),
                                 enabled = true,
                                 onClick = navigationIcon.onClick ?: {}
                             )
+                            else Modifier
+                        )
                             .padding(token.navigationIconPadding(appBarInfo))
                             .size(token.leftIconSize(appBarInfo)),
                         tint = token.navigationIconColor(appBarInfo)
@@ -261,7 +266,8 @@ fun AppBar(
                         text = title,
                         modifier = Modifier
                             .padding(token.textPadding(appBarInfo))
-                            .weight(1F),
+                            .weight(1F)
+                            .semantics { heading() },
                         style = titleTextStyle.merge(
                             TextStyle(
                                 color = token.titleTextColor(appBarInfo)