Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ducking seems to work globally #315

Open
jabdoa2 opened this issue Mar 14, 2018 · 5 comments
Open

Ducking seems to work globally #315

jabdoa2 opened this issue Mar 14, 2018 · 5 comments
Assignees
Labels

Comments

@jabdoa2
Copy link
Collaborator

jabdoa2 commented Mar 14, 2018

My sound config looks like this:

sound_system:
  tracks:
    voice:
      volume: 0.9
      priority: 2
      simultaneous_sounds: 1
      preload: true
      ducking:
        target: music
        delay: 0
        attack: 0.3 sec
        attenuation: 0.45
        release_point: 0.5 sec
        release: 1.0 sec
    sfx:
      volume: 0.9
      priority: 1
      preload: true
      simultaneous_sounds: 3
    music:
      volume: 0.4
      simultaneous_sounds: 1
  buffer: 2048  # previous value was 512
  frequency: 44100
  channels: 1
  master_volume: 0.8
  enabled: true

Ducking works fine and sounds awesome for all callouts. However, I noticed that it also applies to all my sounds in the sfx track. When I remove ducking for callouts it also disappears for sfx. Any idea why that happens and how to fix it?

@qcapen
Copy link
Collaborator

qcapen commented Mar 14, 2018

I'm surprised it works at all assigning it at the track level as it is a sound asset property and not associated with any track attributes.

How about assigning it in the default asset settings as follows:

assets:
    sounds:
        default:
            load: preload
        voice:
            load: preload
            track: voice
            ducking:
              target: music
              delay: 0
              attack: 0.3 sec
              attenuation: 0.45
              release_point: 0.5 sec
              release: 1.0 sec

@jabdoa2
Copy link
Collaborator Author

jabdoa2 commented Mar 14, 2018

I can try that. I think I added that loading from the track stuff a while back.

@jabdoa2
Copy link
Collaborator Author

jabdoa2 commented Mar 14, 2018

I tried the assets config way and it also happens. Dunno why. I verified that the sounds play in the right track (in verbose log).

@qcapen
Copy link
Collaborator

qcapen commented Mar 14, 2018 via email

@qcapen qcapen added the bug label Mar 17, 2018
@qcapen qcapen added this to the 0.50 milestone Mar 17, 2018
@qcapen
Copy link
Collaborator

qcapen commented Mar 17, 2018

Wrote simple test to check sound ducking settings and they are getting set correctly using the assets config method. Now I need to dive in deeper and see if I can replicate the issue.

@jabdoa2 jabdoa2 removed this from the 0.50 milestone Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants