Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Potential Link Executor Selection #2842

Closed
d3vco opened this issue Nov 7, 2023 · 3 comments · Fixed by #2843
Closed

Bug: Potential Link Executor Selection #2842

d3vco opened this issue Nov 7, 2023 · 3 comments · Fixed by #2843
Assignees
Labels

Comments

@d3vco
Copy link
Contributor

d3vco commented Nov 7, 2023

Describe the bug
When adding a potential link to an operation, the executor is automatically selected to be the first match between the agent's executor name and one of the ability's executor names. This can lead to the wrong platform being selected if the ability has two executors with the same name (i.e. "sh") on different platforms (i.e. "darwin" and "linux").

To Reproduce
Steps to reproduce the behavior:

  1. Fresh install Caldera 4.20 with stockpile plugin included
  2. Deploy an agent to a linux platform
  3. Start a new operation
  4. Open the add potential link modal
  5. Select the linux agent
  6. Select the "sh" executor
  7. Search for and select the "Parse ssh config" ability
  8. Observe that the command populated on the next screen is the darwin specific command (pip install stormssh && storm list)

Expected behavior
Following the steps above, the pre-populated command should be the linux command: pip install -q stormssh 2> /dev/null && storm list | sed 's/\x1b\[[0-9;]*m//g'

Reference: Parse ssh config ability file

Desktop (please complete the following information):

  • OS: Mac
  • Browser Firefox
  • Version 4.2.0

Fix
I have created a bug fix and will be linking my pr to this issue

Copy link

github-actions bot commented Nov 7, 2023

Looks like your first issue -- we aim to respond to issues as quickly as possible. In the meantime, check out our documentation here: http://caldera.readthedocs.io/

Copy link

github-actions bot commented Dec 8, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants