Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Heading has no slot attribute #1179

Open
LukasFritzeDev opened this issue Feb 16, 2025 · 1 comment
Open

Modal: Heading has no slot attribute #1179

LukasFritzeDev opened this issue Feb 16, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@LukasFritzeDev
Copy link
Member

When using a <Modal> as described in the Flow documentation I get this warning in the Browser console:

If a Dialog does not contain a <Heading slot="title">, it must have an aria-label or aria-labelledby attribute for accessibility.

The example in the documentation should be fixed so this warning is handled by the example code.
@LukasFritzeDev LukasFritzeDev added the documentation Improvements or additions to documentation label Feb 16, 2025
@LukasFritzeDev
Copy link
Member Author

As discussed with @Lisa18289 the heading should get the slot automatically, but there seems to be a bug with the tunnel behaviour.

@LukasFritzeDev LukasFritzeDev added bug Something isn't working and removed documentation Improvements or additions to documentation labels Feb 17, 2025
@LukasFritzeDev LukasFritzeDev changed the title Modal example: Heading has no slot attribute Modal: Heading has no slot attribute Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasFritzeDev