script works partially on ubuntu

[joel-costigliola]

most of the regex end with reference to non-existent subpattern error.

It looks like the problem is on resolving the expected parameter, for example

assertThat(1.0, is(closeTo(2.0, 1.0)));

gives:

assertThat(1.0).isCloseTo(, within());

Is that due to my perl version ?

~/prog/assertj/hamcrest-to-assertj ∙ perl -v

This is perl 5, version 22, subversion 1 (v5.22.1) built for x86_64-linux-gnu-thread-multi
(with 69 registered patches, see perl -V for more detail)

hamcrest-to-assertj.sh ouput

~/prog/assertj/hamcrest-to-assertj ∙ ./hamcrest-to-assertj.sh
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
        Assert.assertThat(6, IsNull.notNullValue());
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
        assertThat(emptyList(), emptyIterable());
        assertThat(emptyList(), is(emptyIterable()));
        assertThat(asList(0, 1), not(emptyIterable()));
        assertThat(asList(0, 1), is(not(emptyIterable())));
        assertThat(asList(0, 1), not(emptyIterable()));
        assertThat(asList(0, 1), is(not(emptyIterable())));
        assertThat(new Object[]{}, emptyArray());
        assertThat(new Object[]{}, is(emptyArray()));
        assertThat(new Object[]{1}, not(emptyArray()));
        assertThat(new Object[]{1}, is(not(emptyArray())));
        assertThat(new Object[]{1}, not(emptyArray()));
        assertThat(new Object[]{1}, is(not(emptyArray())));
        assertThat(emptyList(), empty());
        assertThat(emptyList(), is(empty()));
        assertThat(asList(0, 1), not(empty()));
        assertThat(asList(0, 1), is(not(empty())));
        assertThat("", isEmptyString());
        assertThat("a", not(isEmptyString()));
        assertThat("a", not(isEmptyString()));
        assertThat(NULL_STRING, isEmptyOrNullString());
        assertThat("a", not(isEmptyOrNullString()));
        assertThat("a", not(isEmptyOrNullString()));
        assertThat(asList(0, 1), not(empty()));
        assertThat(asList(0, 1), is(not(empty())));
        assertThat("", notNullValue());
        assertThat("", is(notNullValue()));
        assertThat("", not(nullValue()));
        assertThat("", is(not(nullValue())));
        assertThat(NULL_STRING, nullValue());
        assertThat(NULL_STRING, is(nullValue()));
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
        assertThat(1.0, is(closeTo(2.0, 1.0)));
        assertThat(1.0, closeTo(2.0, 1.0));
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern
grep: reference to non-existent subpattern

[joel-costigliola]

I have played a bit with the regex but they are a bit too complex for my humble knowledge.

[Fachher]

Maybe to late for you, but I have fixed the problem.
https://github.com/Fachher/hamcrest-to-assertj/commits/master
https://github.com/Fachher/hamcrest-to-assertj/commit/7730a2b6cd24964d7d7b13e6b16ca32d2f4becf2

I will create a pullrequest soon

[mkordas]

@Fachher thanks for that, looks great. Can you create a PR?

[Fachher]

@mkordas You have a pullrequest.