Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent and clean Context implementation #348

Open
raviqqe opened this issue Oct 13, 2023 · 1 comment
Open

Consistent and clean Context implementation #348

raviqqe opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@raviqqe
Copy link
Member

raviqqe commented Oct 13, 2023 •
edited
Loading

This was referenced Oct 13, 2023
Open
Merged
raviqqe added a commit that referenced this issue Oct 17, 2023
@raviqqe
Initialize string cache in context (#349)
c15cecf 
This PR removes the global static string cache that stores `CString` in
MLIR (C++) for each corresponding `&str` in Rust. Instead, we have a
cache in each context. And, that forces users to pass around the new
`Context` type accordingly.

Close #54.

This change is also the base of #271, #23, and #348.
@raviqqe raviqqe mentioned this issue Oct 17, 2023
Merged
@raviqqe
Copy link
Member Author

raviqqe commented Oct 17, 2023

The last thing we should consider and potentially improve is the argument to callback_initialize in the external_pass module.

@raviqqe raviqqe mentioned this issue Oct 18, 2023
Merged
raviqqe added a commit that referenced this issue Oct 18, 2023
@raviqqe
Deprecate StringRef::from_str (#357)
46439ee 
Part of #348.
@raviqqe raviqqe added the enhancement New feature or request label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raviqqe