Use config file for redbot_cli #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnot
reviewed
Nov 17, 2022
|
|
||
| config_parser = ConfigParser() | ||
| config_parser.read_dict({"redbot": {"lang": "en", "charset": "utf-8"}}) | ||
| config_parser.read(os.environ.get("REDBOT_CONFIG", "config.txt")) |
Owner
There was a problem hiding this comment.
I suspect it'd be better to use $XDG_CONFIG_HOME, defaulting to $HOME/.config as per the spec.
Something like:
Suggested change
| config_parser.read(os.environ.get("REDBOT_CONFIG", "config.txt")) | |
| home_dir = os.environ.get("HOME") | |
| config_dir = os.environ.get("XDG_CONFIG_HOME", f"{home_dir}/.config") | |
| config_loc = f"{config_dir}/redbot.cfg" | |
| if os.path.exists(config_loc): | |
| config_parser.read(config_loc) | |
| else: | |
| config_parser.read_dict({"redbot": {"lang": "en", "charset": "utf-8"}}) |
(not tested)
Contributor
Author
There was a problem hiding this comment.
I copied how to read the config file from https://github.com/mnot/redbot/blob/main/bin/redbot_cgi.py#L82
I guess both ways are fine, but it is probably least confusing if all files use the same mechanism to read the config file.
Owner
There was a problem hiding this comment.
redbot_cgi.py is no more, so that shouldn't be an issue any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
redbot_cliuses a fixed config that is not easy to change.The changes make
redbot_cliuse the same config file as the other services.